Implement 'invalid' AutocompleteErrorEvent#reason

chrome/browser/ui/autofill/autofill_dialog_controller_impl.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_UI_AUTOFILL_AUTOFILL_DIALOG_CONTROLLER_IMPL_H_
 #define CHROME_BROWSER_UI_AUTOFILL_AUTOFILL_DIALOG_CONTROLLER_IMPL_H_
 
 #include <set>
 #include <vector>
 
 #include "base/callback.h"
+#include "base/gtest_prod_util.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/memory/weak_ptr.h"
 #include "base/strings/string16.h"
 #include "base/time.h"
 #include "chrome/browser/ui/autofill/account_chooser_model.h"
 #include "chrome/browser/ui/autofill/autofill_dialog_controller.h"
 #include "chrome/browser/ui/autofill/autofill_dialog_models.h"
 #include "chrome/browser/ui/autofill/autofill_dialog_types.h"
 #include "chrome/browser/ui/autofill/autofill_popup_controller_impl.h"
 #include "chrome/browser/ui/autofill/country_combobox_model.h"
@@ skipping 258 matching lines @@
   virtual void OpenTabWithUrl(const GURL& url);
 
   // Whether |section| was sent into edit mode based on existing data. This
   // happens when a user clicks "Edit" or a suggestion is invalid.
   virtual bool IsEditingExistingData(DialogSection section) const;
 
   // Should be called on the Wallet sign-in error.
   virtual void OnWalletSigninError();
 
  private:
+  FRIEND_TEST_ALL_PREFIXES(AutofillDialogControllerTest, AutocompleteEvent);
+  FRIEND_TEST_ALL_PREFIXES(AutofillDialogControllerTest,
+                           AutocompleteErrorEventReasonInvalid);
+  FRIEND_TEST_ALL_PREFIXES(AutofillDialogControllerTest,
+                           AutocompleteErrorEventReasonCancel);

[Ilya Sherman, 2013/06/19 23:56:14]

Why do we need to friend the tests?  IMO it's much better to expose subsets of
the private functionality to tests, rather than letting tests muck with
internals arbitrarily.

[Dan Beam, 2013/06/20 00:26:57]

AutofillDialogControllerImpl::view() (not TestAutofillDialogController)

[Ilya Sherman, 2013/06/20 01:11:27]

I'd much rather expose a GetTestableView() method publicly than add friend
tests.

[Dan Beam, 2013/06/20 01:47:09]

Done.

+
   // Whether or not the current request wants credit info back.
   bool RequestingCreditCardInfo() const;
 
   // Whether the information input in this dialog will be securely transmitted
   // to the requesting site.
   bool TransmissionWillBeSecure() const;
 
   // Initializes |suggested_email_| et al.
   void SuggestionsUpdated();
 
@@ skipping 368 matching lines @@
 
   // Whether the latency to display to the UI was logged to UMA yet.
   bool was_ui_latency_logged_;
 
   DISALLOW_COPY_AND_ASSIGN(AutofillDialogControllerImpl);
 };
 
 }  // namespace autofill
 
 #endif  // CHROME_BROWSER_UI_AUTOFILL_AUTOFILL_DIALOG_CONTROLLER_IMPL_H_