Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(335)

Unified Diff: Source/WebKit/chromium/src/WebPasswordFormUtils.cpp

Issue 17381010: Introduce toHTMLFormControlElement, and use it. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: rebase Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/WebKit/chromium/src/WebFormElement.cpp ('k') | Source/WebKit/chromium/src/WebSearchableFormData.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/WebKit/chromium/src/WebPasswordFormUtils.cpp
diff --git a/Source/WebKit/chromium/src/WebPasswordFormUtils.cpp b/Source/WebKit/chromium/src/WebPasswordFormUtils.cpp
index e6eb92c6212637e63d2baca114ba3e80eaea2e4f..6bac3ef4edfd5069c2165f0716de30b84ebb6a34 100644
--- a/Source/WebKit/chromium/src/WebPasswordFormUtils.cpp
+++ b/Source/WebKit/chromium/src/WebPasswordFormUtils.cpp
@@ -65,14 +65,14 @@ void findPasswordFormFields(HTMLFormElement* form, PasswordFormFields* fields)
for (size_t i = 0; i < formElements.size(); i++) {
if (!formElements[i]->isFormControlElement())
continue;
- HTMLFormControlElement* formElement = static_cast<HTMLFormControlElement*>(formElements[i]);
- if (formElement->isActivatedSubmit())
- fields->submit = formElement;
+ HTMLFormControlElement* control = toHTMLFormControlElement(formElements[i]);
+ if (control->isActivatedSubmit())
+ fields->submit = control;
- if (!formElement->hasTagName(HTMLNames::inputTag))
+ if (!control->hasTagName(HTMLNames::inputTag))
continue;
- HTMLInputElement* inputElement = toHTMLInputElement(formElement);
+ HTMLInputElement* inputElement = toHTMLInputElement(control);
if (inputElement->isDisabledFormControl())
continue;
« no previous file with comments | « Source/WebKit/chromium/src/WebFormElement.cpp ('k') | Source/WebKit/chromium/src/WebSearchableFormData.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698