Source/WebKit/chromium/src/WebFormElement.cpp - Issue 17381010: Introduce toHTMLFormControlElement, and use it.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/WebKit/chromium/src/WebFormElement.cpp

Issue 17381010: Introduce toHTMLFormControlElement, and use it. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: rebase Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/WebKit/chromium/src/WebFormElement.cpp

diff --git a/Source/WebKit/chromium/src/WebFormElement.cpp b/Source/WebKit/chromium/src/WebFormElement.cpp

index 4f5564d00bb681a3fa42764ed6e9fce04e24868a..58c60c3ce2cc60390e7a8557f381744d4fda76af 100644

--- a/Source/WebKit/chromium/src/WebFormElement.cpp

+++ b/Source/WebKit/chromium/src/WebFormElement.cpp

@@ -94,7 +94,7 @@ void WebFormElement::getFormControlElements(WebVector<WebFormControlElement>& re

for (size_t i = 0; i < form->associatedElements().size(); i++) {

if (!form->associatedElements()[i]->isFormControlElement())

continue;

- HTMLFormControlElement* element = static_cast<HTMLFormControlElement*>(form->associatedElements()[i]);

+ HTMLFormControlElement* element = toHTMLFormControlElement(form->associatedElements()[i]);

if (element->hasLocalName(HTMLNames::inputTag)

|| element->hasLocalName(HTMLNames::selectTag))

tempVector.append(element);