Remove the 'http_lock' and 'file_lock' code from webkitpy.

Remove the 'http_lock' and 'file_lock' code from webkitpy.

We used to allow running run-webkit-tests concurrently and they would
coordinate amongst themselves when running the http tests using file
locks. This was used by the Qt port on their buildbots, but it's not
clear that this was needed anywhere else.

This patch removes all of that code, and deletes the generic file lock
module we had as it was now only being used when parsing ASAN logs,
which is only needed on mac and linux (where we can just use flock).

This patch also moves starting and stopping the servers from the
layout_test_runner to the manager, where we can wait to stop the servers
until after retrying any tests. This keeps us from having to start the
servers twice if we need to retry an HTTP test. This will speed up
HTTP retries a tiny bit, but slow down the overall run-webkit-tests
execution a bit in the normal case (no HTTP retries). This tradeoff
seems worth it in order to simplify the logic overall.

R=abarth@chromium.org, ojan@chromium.org
BUG=252035
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=152975

[ojan, 2013-06-20 01:16:49]

lgtm

[commit-bot: I haz the power, 2013-06-24 22:38:47]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dpranke@chromium.org/17320009/4001

[commit-bot: I haz the power, 2013-06-24 22:38:51]

Failed to apply patch for Tools/Scripts/webkitpy/layout_tests/port/base.py:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file Tools/Scripts/webkitpy/layout_tests/port/base.py
  Hunk #1 FAILED at 58.
  Hunk #2 succeeded at 956 (offset 31 lines).
  Hunk #3 succeeded at 974 (offset 31 lines).
  1 out of 3 hunks FAILED -- saving rejects to file
Tools/Scripts/webkitpy/layout_tests/port/base.py.rej

Patch:       Tools/Scripts/webkitpy/layout_tests/port/base.py
Index: Tools/Scripts/webkitpy/layout_tests/port/base.py
diff --git a/Tools/Scripts/webkitpy/layout_tests/port/base.py
b/Tools/Scripts/webkitpy/layout_tests/port/base.py
index
b6fa8a1c30815dd1606e685dbf71cfd7c65af25e..f03d32c7cc797d24d578326e421c0330147aa69c
100644
--- a/Tools/Scripts/webkitpy/layout_tests/port/base.py
+++ b/Tools/Scripts/webkitpy/layout_tests/port/base.py
@@ -58,7 +58,6 @@ from
webkitpy.layout_tests.layout_package.bot_test_expectations import BotTestEx
 from webkitpy.layout_tests.models.test_configuration import TestConfiguration
 from webkitpy.layout_tests.port import config as port_config
 from webkitpy.layout_tests.port import driver
-from webkitpy.layout_tests.port import http_lock
 from webkitpy.layout_tests.port import image_diff
 from webkitpy.layout_tests.port import server_process
 from webkitpy.layout_tests.port.factory import PortFactory
@@ -925,10 +924,6 @@ class Port(object):
             return False
         return True
 
-    def acquire_http_lock(self):
-        self._http_lock = http_lock.HttpLock(None, filesystem=self._filesystem,
executive=self._executive)
-        self._http_lock.wait_for_httpd_lock()
-
     def stop_helper(self):
         """Shut down the test helper if it is running. Do nothing if
         it isn't, or it isn't available. If a port overrides start_helper()
@@ -947,10 +942,6 @@ class Port(object):
             self._websocket_server.stop()
             self._websocket_server = None
 
-    def release_http_lock(self):
-        if self._http_lock:
-            self._http_lock.cleanup_http_lock()
-
     def exit_code_from_summarized_results(self, unexpected_results):
         """Given summarized results, compute the exit code to be returned by
new-run-webkit-tests.
         Bots turn red when this function returns a non-zero value. By default,
return the number of regressions

[commit-bot: I haz the power, 2013-06-24 22:42:59]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dpranke@chromium.org/17320009/11001

[commit-bot: I haz the power, 2013-06-24 23:51:04]

Change committed as 152975