Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(219)

Issue 17302002: Land Recent QUIC changes. (Closed)

Created:
7 years, 6 months ago by ramant (doing other things)
Modified:
7 years, 6 months ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org, wtc, agl
Visibility:
Public.

Description

Land Recent QUIC changes. Merging changes from chromium CL - 16203007 Merge internal change: 48035020 Minor changes from review comments from CL 48035020. Fix http://crbug.com/248737 where QuicSession::ConnectionClose would DCHECK when attempting to close a stream that did not close via ConnectionClose. Add regression test. Merge internal change: 47988326 Added a helper method SetSelfAddress to set the real address. Merge internal change: 47983053 Allow packets to be sent by the client when encryption is first established without waiting for the handshake to be confirmed. Simply doing this made the LargePost test flaky. To deal with *that* problem, I made two more changes: 1) When setting up an RTO for an ENCRYPTION_NONE packet, do not exponentially back off. 2) When an endpoint receives encrypted packets that can not be decrypted buffer some of them and attempt to re-process them when the endpoint moves to the next encryption level. Merge internal change: 47934275 Fix grammatical errors in comments. Merge internal change: 47877973 QUIC: allow replay protection to be configured. Bandaid nodes can't run a shared strike-register (at least, not without a lot of trouble) so would need different orbits for each machine. However, we'll be sending HTTP requests on the QUIC connection anyway - and will be falling back to HTTP in the event of a failure. So there's no actual security. Rather than burn round trips having the clients fetch new server configs each time they talk to a new Bandaid machine, just disable replay protection and give them all the same server config. This change is the QUIC part of disabling replay protection. The GFE config still remains to be done, as does the distribution of server configs to the Bandaid machines. Merge internal change: 47857583 Removing an unnecessary API from the quic stream sequencer, cleaning up an obsolete GFE TODO. We propagate stream RSTs immediately (via PropogateClose gfe-side) so no longer need to pull them from the sequencer. Merge internal change: 47848450 Minor cleanup change for SetNonce in StrikeRegisterTest per wtc's comments in CL: https://codereview.chromium.org/15937012/ R=rch@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=207016

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+397 lines, -202 lines) Patch
M net/quic/crypto/crypto_handshake_test.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M net/quic/crypto/crypto_server_config.h View 4 chunks +13 lines, -1 line 0 comments Download
M net/quic/crypto/crypto_server_config.cc View 5 chunks +30 lines, -16 lines 0 comments Download
M net/quic/crypto/crypto_server_test.cc View 5 chunks +81 lines, -1 line 0 comments Download
M net/quic/crypto/strike_register.h View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/crypto/strike_register_test.cc View 10 chunks +17 lines, -21 lines 0 comments Download
M net/quic/quic_clock.h View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/quic_connection.h View 4 chunks +16 lines, -1 line 0 comments Download
M net/quic/quic_connection.cc View 7 chunks +59 lines, -3 lines 0 comments Download
M net/quic/quic_connection_test.cc View 6 chunks +61 lines, -7 lines 0 comments Download
M net/quic/quic_crypto_client_stream.cc View 2 chunks +3 lines, -15 lines 0 comments Download
M net/quic/quic_session_test.cc View 4 chunks +42 lines, -0 lines 0 comments Download
M net/quic/quic_stream_sequencer.h View 3 chunks +3 lines, -12 lines 0 comments Download
M net/quic/quic_stream_sequencer.cc View 5 chunks +6 lines, -17 lines 0 comments Download
M net/quic/quic_stream_sequencer_test.cc View 4 chunks +10 lines, -89 lines 0 comments Download
M net/quic/reliable_quic_stream.h View 2 chunks +1 line, -2 lines 0 comments Download
M net/quic/reliable_quic_stream.cc View 4 chunks +5 lines, -9 lines 0 comments Download
M net/quic/test_tools/crypto_test_utils.cc View 2 chunks +21 lines, -1 line 0 comments Download
M net/quic/test_tools/crypto_test_utils_openssl.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/test_tools/quic_connection_peer.h View 2 chunks +4 lines, -0 lines 0 comments Download
M net/quic/test_tools/quic_connection_peer.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M net/tools/quic/end_to_end_test.cc View 1 chunk +1 line, -0 lines 0 comments Download
M net/tools/quic/quic_client.h View 1 chunk +3 lines, -0 lines 0 comments Download
M net/tools/quic/quic_client.cc View 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
ramant (doing other things)
7 years, 6 months ago (2013-06-17 18:39:03 UTC) #1
ramant (doing other things)
Hi Ryan, This is a merge of all CL's (7 CLs of yours and 1 ...
7 years, 6 months ago (2013-06-17 18:42:41 UTC) #2
Ryan Hamilton
lgtm
7 years, 6 months ago (2013-06-17 22:40:55 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rtenneti@chromium.org/17302002/1
7 years, 6 months ago (2013-06-17 22:55:36 UTC) #4
commit-bot: I haz the power
Commit queue rejected this change because the description was changed between the time the change ...
7 years, 6 months ago (2013-06-18 13:53:00 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rtenneti@chromium.org/17302002/1
7 years, 6 months ago (2013-06-18 16:38:50 UTC) #6
commit-bot: I haz the power
7 years, 6 months ago (2013-06-18 16:39:29 UTC) #7
Message was sent while issue was closed.
Change committed as 207016

Powered by Google App Engine
This is Rietveld 408576698