Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(186)

Unified Diff: net/quic/quic_crypto_client_stream.cc

Issue 17302002: Land Recent QUIC changes. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/quic/quic_connection_test.cc ('k') | net/quic/quic_session_test.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/quic/quic_crypto_client_stream.cc
diff --git a/net/quic/quic_crypto_client_stream.cc b/net/quic/quic_crypto_client_stream.cc
index 697efe4ce214e6cf176aad6fc123ff5930f54735..674a441e7971a0b62e9c6ee49486139a489cfcbf 100644
--- a/net/quic/quic_crypto_client_stream.cc
+++ b/net/quic/quic_crypto_client_stream.cc
@@ -112,15 +112,9 @@ void QuicCryptoClientStream::DoHandshakeLoop(
session()->connection()->SetDefaultEncryptionLevel(
ENCRYPTION_INITIAL);
if (!encryption_established_) {
- // TODO(agl): the following, commented code should live here and not
- // down when the handshake is confirmed. However, it causes
- // EndToEndTest.LargePost to be flaky (b/8074678), seemingly because
- // the packets dropped when the client hello is dropped cause the
- // congestion control to be too conservative and the server times
- // out.
- // encryption_established_ = true;
- // session()->OnCryptoHandshakeEvent(
- // QuicSession::ENCRYPTION_FIRST_ESTABLISHED);
+ encryption_established_ = true;
+ session()->OnCryptoHandshakeEvent(
+ QuicSession::ENCRYPTION_FIRST_ESTABLISHED);
} else {
session()->OnCryptoHandshakeEvent(
QuicSession::ENCRYPTION_REESTABLISHED);
@@ -226,12 +220,6 @@ void QuicCryptoClientStream::DoHandshakeLoop(
session()->connection()->SetDefaultEncryptionLevel(
ENCRYPTION_FORWARD_SECURE);
- // TODO(agl): this code shouldn't be here. See the TODO further up
- // about it.
- encryption_established_ = true;
- session()->OnCryptoHandshakeEvent(
- QuicSession::ENCRYPTION_FIRST_ESTABLISHED);
-
handshake_confirmed_ = true;
session()->OnCryptoHandshakeEvent(QuicSession::HANDSHAKE_CONFIRMED);
return;
« no previous file with comments | « net/quic/quic_connection_test.cc ('k') | net/quic/quic_session_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698