Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(390)

Issue 17283002: Set max disk cache size correctly. (Closed)

Created:
7 years, 6 months ago by dsinclair
Modified:
7 years, 6 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, rvargas (doing something else)
Visibility:
Public.

Description

Set max disk cache size correctly. Currently we set the max shader cache size too late. The disk cache will be created with a cache size of 0, and the max_cache_size will have no effect. This CL changes the default from 0 to the desired gpu::kDefaultMaxProgramCacheMemoryBytes so we always create the disk cache with the correct size to match the memory cache (currently set to 6MiB). BUG=248511 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=206849

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -11 lines) Patch
M content/browser/gpu/gpu_process_host.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/gpu/gpu_process_host.cc View 4 chunks +2 lines, -4 lines 0 comments Download
M content/browser/gpu/shader_disk_cache.h View 1 2 chunks +0 lines, -4 lines 0 comments Download
M content/browser/gpu/shader_disk_cache.cc View 1 3 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
dsinclair
apatrick, PTAL.
7 years, 6 months ago (2013-06-17 14:55:09 UTC) #1
pasko
lgtm, thanks! thinking aloud: 6MB would be scary for low-end mobile devices, but may actually ...
7 years, 6 months ago (2013-06-17 16:47:28 UTC) #2
pasko
https://codereview.chromium.org/17283002/diff/1/content/browser/gpu/shader_disk_cache.cc File content/browser/gpu/shader_disk_cache.cc (right): https://codereview.chromium.org/17283002/diff/1/content/browser/gpu/shader_disk_cache.cc#newcode506 content/browser/gpu/shader_disk_cache.cc:506: max_cache_size_(gpu::kDefaultMaxProgramCacheMemoryBytes), The field is used only once, directly feeding ...
7 years, 6 months ago (2013-06-17 16:47:37 UTC) #3
apatrick_chromium
LGTM.
7 years, 6 months ago (2013-06-17 18:22:43 UTC) #4
dsinclair
https://codereview.chromium.org/17283002/diff/1/content/browser/gpu/shader_disk_cache.cc File content/browser/gpu/shader_disk_cache.cc (right): https://codereview.chromium.org/17283002/diff/1/content/browser/gpu/shader_disk_cache.cc#newcode506 content/browser/gpu/shader_disk_cache.cc:506: max_cache_size_(gpu::kDefaultMaxProgramCacheMemoryBytes), On 2013/06/17 16:47:37, pasko wrote: > The field ...
7 years, 6 months ago (2013-06-17 18:59:10 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dsinclair@chromium.org/17283002/4002
7 years, 6 months ago (2013-06-17 19:51:14 UTC) #6
commit-bot: I haz the power
7 years, 6 months ago (2013-06-17 23:59:30 UTC) #7
Message was sent while issue was closed.
Change committed as 206849

Powered by Google App Engine
This is Rietveld 408576698