Issue 16153. Auto-complete for import statements.

Issue 16153. Auto-complete for import statements.
https://code.google.com/p/dart/issues/detail?id=16153

R=messick@google.com
BUG=

Committed: https://code.google.com/p/dart/source/detail?r=32865

[messick, 2014-02-20 00:35:30]

Nice! I think people are going to be very happy to see this.

It needs a little clean-up before we can let them have it, though.

https://codereview.chromium.org/172763003/diff/1/editor/tools/plugins/com.goo...
File
editor/tools/plugins/com.google.dart.engine.services/src/com/google/dart/engine/services/completion/CompletionEngine.java
(right):

https://codereview.chromium.org/172763003/diff/1/editor/tools/plugins/com.goo...
editor/tools/plugins/com.google.dart.engine.services/src/com/google/dart/engine/services/completion/CompletionEngine.java:2090:
if (node.getUri().isSynthetic()) {
It looks like you forgot to factor the common code into a helper method.

https://codereview.chromium.org/172763003/diff/1/editor/tools/plugins/com.goo...
editor/tools/plugins/com.google.dart.engine.services/src/com/google/dart/engine/services/completion/CompletionEngine.java:2189:
if (node.getUri().isSynthetic()) {
It looks like you forgot to factor the common code into a helper method.

https://codereview.chromium.org/172763003/diff/1/editor/tools/plugins/com.goo...
File
editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/text/completion/DartCompletionProposal.java
(right):

https://codereview.chromium.org/172763003/diff/1/editor/tools/plugins/com.goo...
editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/text/completion/DartCompletionProposal.java:113:
int exclamationPos = replacementString.indexOf('!');
I'm uneasy about using magic !'s like this. It seems like it will be a
maintenance nightmare.

If you don't want to go to the trouble of making a new kind of completion
proposal then
at least make a constant that can be searched.

[messick, 2014-02-20 00:40:00]

Forgot to say: the ! should not appear in the UI. Just show 'dart:' or
'package:'

[scheglov, 2014-02-20 05:26:37]

PTAL

https://codereview.chromium.org/172763003/diff/1/editor/tools/plugins/com.goo...
File
editor/tools/plugins/com.google.dart.engine.services/src/com/google/dart/engine/services/completion/CompletionEngine.java
(right):

https://codereview.chromium.org/172763003/diff/1/editor/tools/plugins/com.goo...
editor/tools/plugins/com.google.dart.engine.services/src/com/google/dart/engine/services/completion/CompletionEngine.java:2090:
if (node.getUri().isSynthetic()) {
On 2014/02/20 00:35:31, messick wrote:
> It looks like you forgot to factor the common code into a helper method.

Done.

https://codereview.chromium.org/172763003/diff/1/editor/tools/plugins/com.goo...
editor/tools/plugins/com.google.dart.engine.services/src/com/google/dart/engine/services/completion/CompletionEngine.java:2189:
if (node.getUri().isSynthetic()) {
On 2014/02/20 00:35:31, messick wrote:
> It looks like you forgot to factor the common code into a helper method.

Done.

https://codereview.chromium.org/172763003/diff/1/editor/tools/plugins/com.goo...
File
editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/text/completion/DartCompletionProposal.java
(right):

https://codereview.chromium.org/172763003/diff/1/editor/tools/plugins/com.goo...
editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/text/completion/DartCompletionProposal.java:113:
int exclamationPos = replacementString.indexOf('!');
On 2014/02/20 00:35:31, messick wrote:
> I'm uneasy about using magic !'s like this. It seems like it will be a
> maintenance nightmare.
> 
> If you don't want to go to the trouble of making a new kind of completion
> proposal then
> at least make a constant that can be searched.

Done.

[messick, 2014-02-20 19:00:39]

LGTM with one small change.

https://chromiumcodereview.appspot.com/172763003/diff/70001/editor/tools/plug...
File
editor/tools/plugins/com.google.dart.engine.services_test/src/com/google/dart/engine/services/completion/CompletionTests.java
(right):

https://chromiumcodereview.appspot.com/172763003/diff/70001/editor/tools/plug...
editor/tools/plugins/com.google.dart.engine.services_test/src/com/google/dart/engine/services/completion/CompletionTests.java:24:
private static String importUri(String uri) {
This should be visible to CompletionLibraryTests.

[scheglov, 2014-02-20 19:18:11]

Committed patchset #2 manually as r32865 (presubmit successful).

[scheglov, 2014-02-20 19:20:12]

https://chromiumcodereview.appspot.com/172763003/diff/70001/editor/tools/plug...
File
editor/tools/plugins/com.google.dart.engine.services_test/src/com/google/dart/engine/services/completion/CompletionTests.java
(right):

https://chromiumcodereview.appspot.com/172763003/diff/70001/editor/tools/plug...
editor/tools/plugins/com.google.dart.engine.services_test/src/com/google/dart/engine/services/completion/CompletionTests.java:24:
private static String importUri(String uri) {
On 2014/02/20 19:00:39, messick wrote:
> This should be visible to CompletionLibraryTests.

Moved to CompletionTests.