editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/text/dart/CompletionProposalLabelProvider.java - Issue 172763003: Issue 16153. Auto-complete for import statements.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/text/dart/CompletionProposalLabelProvider.java

Issue 172763003: Issue 16153. Auto-complete for import statements. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Extract helper and use marker constant Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« editor/tools/plugins/com.google.dart.engine.services_test/src/com/google/dart/engine/services/completion/CompletionTests.java ('K') | « editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/text/completion/DartCompletionProposal.java ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/text/dart/CompletionProposalLabelProvider.java

diff --git a/editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/text/dart/CompletionProposalLabelProvider.java b/editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/text/dart/CompletionProposalLabelProvider.java

index b2627f206d8a7b1d29aaa317ee76ce5eb3641e7a..3cef3bcedb5a39d8611c9c9968c92a3c16227c80 100644

--- a/editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/text/dart/CompletionProposalLabelProvider.java

+++ b/editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/text/dart/CompletionProposalLabelProvider.java

@@ -26,6 +26,7 @@ import com.google.dart.tools.ui.internal.util.TypeLabelUtil;

import com.google.dart.tools.ui.internal.viewsupport.DartElementImageProvider;

import com.google.dart.tools.ui.text.editor.tmp.Signature;

+import org.apache.commons.lang3.StringUtils;

import org.eclipse.core.runtime.Assert;

import org.eclipse.jface.resource.ImageDescriptor;

import org.eclipse.jface.viewers.StyledString;

@@ -461,7 +462,8 @@ public class CompletionProposalLabelProvider {

}

String createSimpleLabel(CompletionProposal proposal) {

- return String.valueOf(proposal.getCompletion());

+ String label = String.valueOf(proposal.getCompletion());

+ return StringUtils.remove(label, CompletionProposal.CURSOR_MARKER);

}

String createSimpleLabelWithType(CompletionProposal proposal) {