Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(390)

Issue 1726123002: Skip more resource-hogging tests on arm64. (Closed)

Created:
4 years, 10 months ago by rmacnak
Modified:
4 years, 10 months ago
Reviewers:
zra
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 3

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -7 lines) Patch
M tests/language/language.status View 1 1 chunk +3 lines, -0 lines 0 comments Download
M tests/standalone/standalone.status View 1 1 chunk +4 lines, -7 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
rmacnak
4 years, 10 months ago (2016-02-23 22:56:48 UTC) #2
zra
https://chromiumcodereview.appspot.com/1726123002/diff/1/tests/standalone/standalone.status File tests/standalone/standalone.status (right): https://chromiumcodereview.appspot.com/1726123002/diff/1/tests/standalone/standalone.status#newcode123 tests/standalone/standalone.status:123: precompilation_test: SkipSlow Isn't this exactly the platform where we ...
4 years, 10 months ago (2016-02-23 23:04:09 UTC) #3
rmacnak
https://codereview.chromium.org/1726123002/diff/1/tests/language/language.status File tests/language/language.status (right): https://codereview.chromium.org/1726123002/diff/1/tests/language/language.status#newcode110 tests/language/language.status:110: stack_overflow_test: Skip # Crashes. Issue 17440. These pass when ...
4 years, 10 months ago (2016-02-24 20:50:41 UTC) #4
zra
lgtm
4 years, 10 months ago (2016-02-24 20:52:46 UTC) #5
rmacnak
4 years, 10 months ago (2016-02-24 20:56:42 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
f3fda729cc20550c3efae6455d6f96f47fbb1973 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698