Implement Mirror.isSubclassOf.

Implement Mirror.isSubclassOf.

R=johnniwinther@google.com

Committed: https://code.google.com/p/dart/source/detail?r=33151

[Johnni Winther, 2014-02-26 15:44:59]

https://codereview.chromium.org/172353003/diff/40001/sdk/lib/_internal/lib/js...
File sdk/lib/_internal/lib/js_mirrors.dart (right):

https://codereview.chromium.org/172353003/diff/40001/sdk/lib/_internal/lib/js...
sdk/lib/_internal/lib/js_mirrors.dart:2533: bool isSubclassOf(ClassMirror other)
=> false;
Should this return true on Function?

https://codereview.chromium.org/172353003/diff/40001/tests/lib/mirrors/relati...
File tests/lib/mirrors/relation_subclass_test.dart (right):

https://codereview.chromium.org/172353003/diff/40001/tests/lib/mirrors/relati...
tests/lib/mirrors/relation_subclass_test.dart:60: var NumPred =
reflectType(NumberPredicate);
Why this change?

[karlklose, 2014-02-27 08:41:02]

https://chromiumcodereview.appspot.com/172353003/diff/40001/sdk/lib/_internal...
File sdk/lib/_internal/lib/js_mirrors.dart (right):

https://chromiumcodereview.appspot.com/172353003/diff/40001/sdk/lib/_internal...
sdk/lib/_internal/lib/js_mirrors.dart:2533: bool isSubclassOf(ClassMirror other)
=> false;
On 2014/02/26 15:44:59, Johnni Winther wrote:
> Should this return true on Function?

I don't know, for me the predicate does not make sense on types.

It could, since we also implement JsTypeBoundMirror.isSubclassOf by going to the
class declaration. On the other hand, the VM returns false.

What is the usage scenario? Shouldn't the user rather use 'is
FunctionTypeMirror' to find out if a type is a function type?

https://chromiumcodereview.appspot.com/172353003/diff/40001/tests/lib/mirrors...
File tests/lib/mirrors/relation_subclass_test.dart (right):

https://chromiumcodereview.appspot.com/172353003/diff/40001/tests/lib/mirrors...
tests/lib/mirrors/relation_subclass_test.dart:60: var NumPred =
reflectType(NumberPredicate);
On 2014/02/26 15:44:59, Johnni Winther wrote:
> Why this change?

We do not preserve the typedef declarations in dart2js.
(https://code.google.com/p/dart/issues/detail?id=16939)

I will add a comment to change it back when we implement the feature.

[Johnni Winther, 2014-02-27 10:54:20]

lgtm

https://chromiumcodereview.appspot.com/172353003/diff/40001/sdk/lib/_internal...
File sdk/lib/_internal/lib/js_mirrors.dart (right):

https://chromiumcodereview.appspot.com/172353003/diff/40001/sdk/lib/_internal...
sdk/lib/_internal/lib/js_mirrors.dart:2533: bool isSubclassOf(ClassMirror other)
=> false;
On 2014/02/27 08:41:02, karlklose wrote:
> On 2014/02/26 15:44:59, Johnni Winther wrote:
> > Should this return true on Function?
> 
> I don't know, for me the predicate does not make sense on types.
> 
> It could, since we also implement JsTypeBoundMirror.isSubclassOf by going to
the
> class declaration. On the other hand, the VM returns false.
> 
> What is the usage scenario? Shouldn't the user rather use 'is
> FunctionTypeMirror' to find out if a type is a function type?

Go with the VM.

https://chromiumcodereview.appspot.com/172353003/diff/60001/tests/lib/mirrors...
File tests/lib/mirrors/relation_subclass_test.dart (right):

https://chromiumcodereview.appspot.com/172353003/diff/60001/tests/lib/mirrors...
tests/lib/mirrors/relation_subclass_test.dart:60: // TODO(16939): retrieve via
decleration when dart2js supports it.
Retrieve ... declaration ...

[karlklose, 2014-02-28 09:39:00]

Committed patchset #3 manually as r33151 (presubmit successful).