Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issue 17209003: Enable low latency mode for audio playback on Android (Closed)

Created:
7 years, 6 months ago by wjia(left Chromium)
Modified:
7 years, 6 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, feature-media-reviews_chromium.org, jam, darin-cc_chromium.org, punyabrata
Visibility:
Public.

Description

Enable low latency mode for audio playback on Android On Android, in order to use low latency mode for audio playback, it's required to use exact sampling rate and buffer size queried from the device. This patch uses 2048 frames for IPC buffer and native size (queried from device) for buffer sent to the device. BUG=243506 TEST=run https://apprtc.appspot.com/?debug=loopback on Google Android devices, e.g., Galaxy Nexus, Nexus4. The audio quality is much better than the exisiting setup. R=dalecurtis@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=206821

Patch Set 1 #

Patch Set 2 : #

Total comments: 2

Patch Set 3 : code review, add TEST= line #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -5 lines) Patch
M content/renderer/media/webrtc_audio_renderer.cc View 2 chunks +6 lines, -0 lines 0 comments Download
M media/audio/android/audio_manager_android.cc View 1 2 1 chunk +1 line, -5 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
wjia(left Chromium)
I'd move forward with this simple patch first to enable low latency audio playback on ...
7 years, 6 months ago (2013-06-17 21:41:03 UTC) #1
DaleCurtis
lgtm % adding a TEST= line to the description with some discussion on how this ...
7 years, 6 months ago (2013-06-17 21:49:08 UTC) #2
DaleCurtis
https://chromiumcodereview.appspot.com/17209003/diff/4001/media/audio/android/audio_manager_android.cc File media/audio/android/audio_manager_android.cc (left): https://chromiumcodereview.appspot.com/17209003/diff/4001/media/audio/android/audio_manager_android.cc#oldcode129 media/audio/android/audio_manager_android.cc:129: // Return the optimal size as a multiple of ...
7 years, 6 months ago (2013-06-17 21:49:53 UTC) #3
wjia(left Chromium)
Thanks! https://chromiumcodereview.appspot.com/17209003/diff/4001/media/audio/android/audio_manager_android.cc File media/audio/android/audio_manager_android.cc (left): https://chromiumcodereview.appspot.com/17209003/diff/4001/media/audio/android/audio_manager_android.cc#oldcode129 media/audio/android/audio_manager_android.cc:129: // Return the optimal size as a multiple ...
7 years, 6 months ago (2013-06-17 22:04:09 UTC) #4
DaleCurtis
Make sure you test a WebAudio demo too.
7 years, 6 months ago (2013-06-17 22:05:12 UTC) #5
wjia(left Chromium)
7 years, 6 months ago (2013-06-17 22:55:33 UTC) #6
Message was sent while issue was closed.
Committed patchset #3 manually as r206821 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698