allow unofficial builds with DCHECK and DLOG disabled

allow unofficial builds with DCHECK and DLOG disabled

Previously, it was not possible to produce unofficial builds without
DCHECKS and DLOGS.

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=207826

[Mostyn Bramley-Moore, 2013-06-19 14:43:01]

Following up from David Turner's recent comments re DCHECK and DLOG on
chromium-dev:
"You can only disable these by doing an OFFICIAL_BUILD, and I'm not sure how to
configure these outside of official Chrome builds, but I assume this can be
forced with a magic GYP_DEFINES variable."

It does not seem to be possible to do this without making an official build,
which I don't want to do (because I make use of shim headers which is forbidden
for official builds).

@mark: does this look reasonable to you?

[Mark Mentovai, 2013-06-20 16:09:42]

https://codereview.chromium.org/17165003/diff/1/build/common.gypi
File build/common.gypi (right):

https://codereview.chromium.org/17165003/diff/1/build/common.gypi#newcode206
build/common.gypi:206: 'logging_is_official_build%': 0,
_like_ makes more sense than _is_.

Document that this is ignored in real official builds.

[Mostyn Bramley-Moore, 2013-06-20 19:24:30]

https://codereview.chromium.org/17165003/diff/1/build/common.gypi
File build/common.gypi (right):

https://codereview.chromium.org/17165003/diff/1/build/common.gypi#newcode206
build/common.gypi:206: 'logging_is_official_build%': 0,
On 2013/06/20 16:09:42, Mark Mentovai wrote:
> _like_ makes more sense than _is_.
> 
> Document that this is ignored in real official builds.

Done in patchset 2.

I also rejigged the ifdeffery to make sure this setting does not affect official
builds or debug builds.

[Mark Mentovai, 2013-06-20 19:27:24]

Very good. LGTM.

[commit-bot: I haz the power, 2013-06-20 19:32:19]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mostynb@opera.com/17165003/5001

[commit-bot: I haz the power, 2013-06-21 15:24:02]

Change committed as 207826