Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2856)

Unified Diff: build/common.gypi

Issue 17165003: allow unofficial builds with DCHECK and DLOG disabled (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rename _is_ to _like_ in gyp setting and rejig ifdeffery Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « base/logging.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/common.gypi
diff --git a/build/common.gypi b/build/common.gypi
index 23d053034a67ba6bb6eff93af0d697375d076a50..870bca910a9b9b83fb892a79740925d4b41ca0da 100644
--- a/build/common.gypi
+++ b/build/common.gypi
@@ -201,6 +201,12 @@
# Set to 1 to enable dcheck in release without having to use the flag.
'dcheck_always_on%': 0,
+ # Set to 1 to make a build that logs like an official build, but is not
+ # necessarily an official build, ie DCHECK and DLOG are disabled and
+ # removed completely in release builds, to minimize binary footprint.
+ # Note: this setting is ignored if buildtype=="Official".
+ 'logging_like_official_build%': 0,
+
# Disable file manager component extension by default.
'file_manager_extension%': 0,
@@ -761,6 +767,7 @@
'image_loader_extension%': '<(image_loader_extension)',
'fastbuild%': '<(fastbuild)',
'dcheck_always_on%': '<(dcheck_always_on)',
+ 'logging_like_official_build%': '<(logging_like_official_build)',
'python_ver%': '<(python_ver)',
'arm_version%': '<(arm_version)',
'armv7%': '<(armv7)',
@@ -2047,6 +2054,9 @@
['dcheck_always_on!=0', {
'defines': ['DCHECK_ALWAYS_ON=1'],
}], # dcheck_always_on!=0
+ ['logging_like_official_build!=0', {
+ 'defines': ['LOGGING_IS_OFFICIAL_BUILD=1'],
+ }], # logging_like_official_build!=0
['win_use_allocator_shim==0', {
'conditions': [
['OS=="win"', {
« no previous file with comments | « base/logging.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698