cc: Remove cc::Thread and cc::ThreadImpl.

cc: Remove cc::Thread and cc::ThreadImpl.

These classes are replaced by using base::SingleThreadTaskRunner
directly.

R=piman,jamesr
BUG=251134
Depends on: https://codereview.chromium.org/17362002/

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=207491

[piman, 2013-06-18 17:56:25]

lgtm

https://codereview.chromium.org/17114008/diff/8001/cc/layers/delegated_render...
File cc/layers/delegated_renderer_layer_impl_unittest.cc (right):

https://codereview.chromium.org/17114008/diff/8001/cc/layers/delegated_render...
cc/layers/delegated_renderer_layer_impl_unittest.cc:36: : proxy_(),
nit: remove redundant default initializer.

https://codereview.chromium.org/17114008/diff/8001/cc/resources/resource_upda...
File cc/resources/resource_update_controller_unittest.cc (right):

https://codereview.chromium.org/17114008/diff/8001/cc/resources/resource_upda...
cc/resources/resource_update_controller_unittest.cc:73: : proxy_(),
nit: remove redundant default initializer

https://codereview.chromium.org/17114008/diff/8001/cc/trees/layer_tree_host_i...
File cc/trees/layer_tree_host_impl_unittest.cc (right):

https://codereview.chromium.org/17114008/diff/8001/cc/trees/layer_tree_host_i...
cc/trees/layer_tree_host_impl_unittest.cc:64: : proxy_(),
nit: remove redundant default initializer

[danakj, 2013-06-18 18:00:31]

https://codereview.chromium.org/17114008/diff/8001/cc/layers/delegated_render...
File cc/layers/delegated_renderer_layer_impl_unittest.cc (right):

https://codereview.chromium.org/17114008/diff/8001/cc/layers/delegated_render...
cc/layers/delegated_renderer_layer_impl_unittest.cc:36: : proxy_(),
On 2013/06/18 17:56:25, piman wrote:
> nit: remove redundant default initializer.

ah, okay. i thought maybe it is nice, because you can see proxy_ being used just
below in the initializer list, and this shows that it was initialized first
already.

[piman, 2013-06-18 18:09:24]

On Tue, Jun 18, 2013 at 11:00 AM, <danakj@chromium.org> wrote:

>
> https://codereview.chromium.**org/17114008/diff/8001/cc/**
>
layers/delegated_renderer_**layer_impl_unittest.cc<https://codereview.chromium.org/17114008/diff/8001/cc/layers/delegated_renderer_layer_impl_unittest.cc>
> File cc/layers/delegated_renderer_**layer_impl_unittest.cc (right):
>
> https://codereview.chromium.**org/17114008/diff/8001/cc/**
>
layers/delegated_renderer_**layer_impl_unittest.cc#**newcode36<https://codereview.chromium.org/17114008/diff/8001/cc/layers/delegated_renderer_layer_impl_unittest.cc#newcode36>
> cc/layers/delegated_renderer_**layer_impl_unittest.cc:36: : proxy_(),
> On 2013/06/18 17:56:25, piman wrote:
>
>> nit: remove redundant default initializer.
>>
>
> ah, okay. i thought maybe it is nice, because you can see proxy_ being
> used just below in the initializer list, and this shows that it was
> initialized first already.
>

I think there's a vague consensus that it's usually simpler to omit it.
I assume compilers would complain if we used a field prior to its
initialization?


>
https://codereview.chromium.**org/17114008/<https://codereview.chromium.org/1...
>

[danakj, 2013-06-18 18:14:56]

On Tue, Jun 18, 2013 at 2:09 PM, Antoine Labour <piman@chromium.org> wrote:

> On Tue, Jun 18, 2013 at 11:00 AM, <danakj@chromium.org> wrote:
>
>>
>> https://codereview.chromium.**org/17114008/diff/8001/cc/**
>>
layers/delegated_renderer_**layer_impl_unittest.cc<https://codereview.chromium.org/17114008/diff/8001/cc/layers/delegated_renderer_layer_impl_unittest.cc>
>> File cc/layers/delegated_renderer_**layer_impl_unittest.cc (right):
>>
>> https://codereview.chromium.**org/17114008/diff/8001/cc/**
>>
layers/delegated_renderer_**layer_impl_unittest.cc#**newcode36<https://codereview.chromium.org/17114008/diff/8001/cc/layers/delegated_renderer_layer_impl_unittest.cc#newcode36>
>> cc/layers/delegated_renderer_**layer_impl_unittest.cc:36: : proxy_(),
>> On 2013/06/18 17:56:25, piman wrote:
>>
>>> nit: remove redundant default initializer.
>>>
>>
>> ah, okay. i thought maybe it is nice, because you can see proxy_ being
>> used just below in the initializer list, and this shows that it was
>> initialized first already.
>>
>
> I think there's a vague consensus that it's usually simpler to omit it.
> I assume compilers would complain if we used a field prior to its
> initialization?
>

Hm ya, I hope so. Okay!


>
>
>>
https://codereview.chromium.**org/17114008/<https://codereview.chromium.org/1...
>>
>
>

[commit-bot: I haz the power, 2013-06-19 00:46:46]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/danakj@chromium.org/17114008/15001

[commit-bot: I haz the power, 2013-06-19 01:11:10]

Sorry for I got bad news for ya.
Compile failed with a clobber build on android_clang_dbg.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_cl...
Your code is likely broken or HEAD is junk. Please ensure your
code is not broken then alert the build sheriffs.
Look at the try server FAQ for more details.

[commit-bot: I haz the power, 2013-06-19 01:22:51]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/danakj@chromium.org/17114008/35001

[commit-bot: I haz the power, 2013-06-19 01:37:43]

Retried try job too often on chromium_presubmit for step(s) presubmit
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_p...

[danakj, 2013-06-19 01:38:18]

TBR=jamesr to remove unused header file

[commit-bot: I haz the power, 2013-06-19 01:38:57]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/danakj@chromium.org/17114008/35001

[danakj, 2013-06-19 02:11:21]

I take back that TBR. jamesr@ please take a look at webkit/ as I had to adjust
the plumbing there for DRT to build.

[jamesr, 2013-06-19 05:17:08]

DRT doesn't build any more.  The only thing using WLTVForTesting are a small set
of unit tests, which never run in threaded mode, so you can just kill all that.

[danakj, 2013-06-19 15:28:59]

On Wed, Jun 19, 2013 at 1:17 AM, <jamesr@chromium.org> wrote:

> DRT doesn't build any more.  The only thing using WLTVForTesting are a
> small set
> of unit tests, which never run in threaded mode, so you can just kill all
> that.
>

Oh okay, somehow I thought content shell would use this. Done!

[jamesr, 2013-06-19 17:33:40]

webkit/ lgtm

https://codereview.chromium.org/17114008/diff/63001/webkit/support/webkit_sup...
File webkit/support/webkit_support.cc (right):

https://codereview.chromium.org/17114008/diff/63001/webkit/support/webkit_sup...
webkit/support/webkit_support.cc:466: DCHECK(thread == NULL);
why not DCHECK_EQ, DCHECK(!thread), or something?

[danakj, 2013-06-19 17:37:01]

Thanks!

https://codereview.chromium.org/17114008/diff/63001/webkit/support/webkit_sup...
File webkit/support/webkit_support.cc (right):

https://codereview.chromium.org/17114008/diff/63001/webkit/support/webkit_sup...
webkit/support/webkit_support.cc:466: DCHECK(thread == NULL);
On 2013/06/19 17:33:41, jamesr wrote:
> why not DCHECK_EQ, DCHECK(!thread), or something?

I'll !thread, was worried about windows but that should work.

[commit-bot: I haz the power, 2013-06-19 17:47:30]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/danakj@chromium.org/17114008/72001

[commit-bot: I haz the power, 2013-06-19 17:49:45]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/danakj@chromium.org/17114008/33003

[commit-bot: I haz the power, 2013-06-20 07:14:02]

Retried try job too often on win_rel for step(s) chrome_frame_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[commit-bot: I haz the power, 2013-06-20 15:01:29]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/danakj@chromium.org/17114008/33003

[commit-bot: I haz the power, 2013-06-20 18:26:20]

Change committed as 207491