Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1538)

Unified Diff: runtime/observatory/lib/src/service/object.dart

Issue 1709383002: Improve behaviour when we hit a stack overflow / OOM error (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/observatory/lib/src/service/object.dart
diff --git a/runtime/observatory/lib/src/service/object.dart b/runtime/observatory/lib/src/service/object.dart
index 78b67659cb2d5cb5c10f6de89740e658d846127e..8666f145919edbb67edaa883f78e5cf7366a9742 100644
--- a/runtime/observatory/lib/src/service/object.dart
+++ b/runtime/observatory/lib/src/service/object.dart
@@ -2325,6 +2325,8 @@ class Instance extends HeapObject {
bool get isWeakProperty => kind == 'WeakProperty';
bool get isClosure => kind == 'Closure';
bool get isStackTrace => kind == 'StackTrace';
+ bool get isStackOverflowError => clazz.name == 'StackOverflowError';
rmacnak 2016/02/22 17:55:27 And library is dart:core.
Cutch 2016/02/22 18:38:17 Done.
+ bool get isOutOfMemoryError => clazz.name == 'OutOfMemoryError';
// TODO(turnidge): Is this properly backwards compatible when new
// instance kinds are added?

Powered by Google App Engine
This is Rietveld 408576698