Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(188)

Side by Side Diff: runtime/observatory/lib/src/service/object.dart

Issue 1709383002: Improve behaviour when we hit a stack overflow / OOM error (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2014, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2014, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 part of service; 5 part of service;
6 6
7 // Some value smaller than the object ring, so requesting a large array 7 // Some value smaller than the object ring, so requesting a large array
8 // doesn't result in an expired ref because the elements lapped it in the 8 // doesn't result in an expired ref because the elements lapped it in the
9 // object ring. 9 // object ring.
10 const int kDefaultFieldLimit = 100; 10 const int kDefaultFieldLimit = 100;
(...skipping 2307 matching lines...) Expand 10 before | Expand all | Expand 10 after
2318 bool get isSimdValue { 2318 bool get isSimdValue {
2319 return kind == 'Float32x4' 2319 return kind == 'Float32x4'
2320 || kind == 'Float64x2' 2320 || kind == 'Float64x2'
2321 || kind == 'Int32x4'; 2321 || kind == 'Int32x4';
2322 } 2322 }
2323 bool get isRegExp => kind == 'RegExp'; 2323 bool get isRegExp => kind == 'RegExp';
2324 bool get isMirrorReference => kind == 'MirrorReference'; 2324 bool get isMirrorReference => kind == 'MirrorReference';
2325 bool get isWeakProperty => kind == 'WeakProperty'; 2325 bool get isWeakProperty => kind == 'WeakProperty';
2326 bool get isClosure => kind == 'Closure'; 2326 bool get isClosure => kind == 'Closure';
2327 bool get isStackTrace => kind == 'StackTrace'; 2327 bool get isStackTrace => kind == 'StackTrace';
2328 bool get isStackOverflowError => clazz.name == 'StackOverflowError';
rmacnak 2016/02/22 17:55:27 And library is dart:core.
Cutch 2016/02/22 18:38:17 Done.
2329 bool get isOutOfMemoryError => clazz.name == 'OutOfMemoryError';
2328 2330
2329 // TODO(turnidge): Is this properly backwards compatible when new 2331 // TODO(turnidge): Is this properly backwards compatible when new
2330 // instance kinds are added? 2332 // instance kinds are added?
2331 bool get isPlainInstance => kind == 'PlainInstance'; 2333 bool get isPlainInstance => kind == 'PlainInstance';
2332 2334
2333 Instance._empty(ServiceObjectOwner owner) : super._empty(owner); 2335 Instance._empty(ServiceObjectOwner owner) : super._empty(owner);
2334 2336
2335 void _update(ObservableMap map, bool mapIsRef) { 2337 void _update(ObservableMap map, bool mapIsRef) {
2336 // Extract full properties. 2338 // Extract full properties.
2337 _upgradeCollection(map, isolate); 2339 _upgradeCollection(map, isolate);
(...skipping 1638 matching lines...) Expand 10 before | Expand all | Expand 10 after
3976 var v = list[i]; 3978 var v = list[i];
3977 if ((v is ObservableMap) && _isServiceMap(v)) { 3979 if ((v is ObservableMap) && _isServiceMap(v)) {
3978 list[i] = owner.getFromMap(v); 3980 list[i] = owner.getFromMap(v);
3979 } else if (v is ObservableList) { 3981 } else if (v is ObservableList) {
3980 _upgradeObservableList(v, owner); 3982 _upgradeObservableList(v, owner);
3981 } else if (v is ObservableMap) { 3983 } else if (v is ObservableMap) {
3982 _upgradeObservableMap(v, owner); 3984 _upgradeObservableMap(v, owner);
3983 } 3985 }
3984 } 3986 }
3985 } 3987 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698