Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(246)

Unified Diff: mojo/shell/public/cpp/lib/application_test_base.cc

Issue 1709173002: mojo: Delay ApplicationTestBase shell disconnection. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: initial approach Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | mojo/tools/data/apptests » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: mojo/shell/public/cpp/lib/application_test_base.cc
diff --git a/mojo/shell/public/cpp/lib/application_test_base.cc b/mojo/shell/public/cpp/lib/application_test_base.cc
index f9a726dbf2c752e033d1e331ba1d9d8d0ac06338..e282822c042198baae8959b11a51791626b9e27c 100644
--- a/mojo/shell/public/cpp/lib/application_test_base.cc
+++ b/mojo/shell/public/cpp/lib/application_test_base.cc
@@ -161,8 +161,6 @@ void ApplicationTestBase::TearDown() {
CHECK(!g_shell_client_request.is_pending());
CHECK(!g_shell);
- test_helper_.reset();
-
if (ShouldCreateDefaultRunLoop())
Environment::DestroyDefaultRunLoop();
msw 2016/02/23 18:02:42 Does the order of closing the connection and destr
msw 2016/02/23 18:03:44 Sorry, ignore this old comment.
xhwang 2016/02/23 18:05:39 Actually it's a good question, and I don't know en
}
« no previous file with comments | « no previous file | mojo/tools/data/apptests » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698