mojo: Delay ApplicationTestBase shell disconnection.

mojo/shell/public/cpp/lib/application_test_base.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <utility>
 
 #include "base/command_line.h"
 #include "base/logging.h"
 #include "base/strings/utf_string_conversions.h"
 #include "mojo/public/cpp/bindings/binding.h"
@@ skipping 143 matching lines @@
   CHECK(g_shell);
 
   // New applications are constructed for each test to avoid persisting state.
   test_helper_.reset(new TestHelper(GetShellClient()));
 }
 
 void ApplicationTestBase::TearDown() {
   CHECK(!g_shell_client_request.is_pending());
   CHECK(!g_shell);
 
-  test_helper_.reset();
-
   if (ShouldCreateDefaultRunLoop())
     Environment::DestroyDefaultRunLoop();

[msw, 2016/02/23 18:02:42]

Does the order of closing the connection and destroying the run loop matter?

[msw, 2016/02/23 18:03:44]

Sorry, ignore this old comment.

[xhwang, 2016/02/23 18:05:39]

Actually it's a good question, and I don't know enough to answer that. It
doesn't matter here since I am not changing the order, but it'd be interesting
to know :)

 }
 
 bool ApplicationTestBase::ShouldCreateDefaultRunLoop() {
   return true;
 }
 
 }  // namespace test
 }  // namespace mojo