Pass Client pointer in Initialize() for VDA/VEA

media/filters/gpu_video_decoder.cc

Index: media/filters/gpu_video_decoder.cc
diff --git a/media/filters/gpu_video_decoder.cc b/media/filters/gpu_video_decoder.cc
index b87041a98b5db6126cdeca5859b64a303e8a0382..0026376c1fe6816699f3240ecb644b97210bc8eb 100644
--- a/media/filters/gpu_video_decoder.cc
+++ b/media/filters/gpu_video_decoder.cc
@@ -190,9 +190,8 @@ void GpuVideoDecoder::Initialize(const VideoDecoderConfig& config,
     return;
   }
 
-  vda_ =
-      factories_->CreateVideoDecodeAccelerator(config.profile(), this).Pass();
-  if (!vda_) {
+  vda_ = factories_->CreateVideoDecodeAccelerator(config.profile()).Pass();
+  if (!vda_ || !vda_->Initialize(this, config.profile())) {

[Ami GONE FROM CHROMIUM, 2014/02/25 00:01:35]

I love this formulation because it crystallizes so well my failure in making the
IPC & VDA interfaces symmetric by highlighting the repetition of the profile
parameter to CreateVDA & Initialize (the second of which is a no-op).
Oh well.

[sheu, 2014/02/25 00:37:16]

I don't think that's innately a failure -- it's more an IPC optimization, which
saves a round-trip by collapsing the construction and initialization.  That
optimization just has some uglier externally-visible effects.

[Ami GONE FROM CHROMIUM, 2014/02/25 00:50:51]

<MadTV>Lowered expectaaations...</MadTV>

     status_cb.Run(DECODER_ERROR_NOT_SUPPORTED);
     return;
   }