Pass Client pointer in Initialize() for VDA/VEA

media/filters/gpu_video_decoder.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "media/filters/gpu_video_decoder.h"
 
 #include <algorithm>
 
 #include "base/bind.h"
 #include "base/callback_helpers.h"
@@ skipping 172 matching lines @@
   needs_bitstream_conversion_ = (config.codec() == kCodecH264);
 
   if (previously_initialized) {
     // Reinitialization with a different config (but same codec and profile).
     // VDA should handle it by detecting this in-stream by itself,
     // no need to notify it.
     status_cb.Run(PIPELINE_OK);
     return;
   }
 
-  vda_ =
-      factories_->CreateVideoDecodeAccelerator(config.profile(), this).Pass();
-  if (!vda_) {
+  vda_ = factories_->CreateVideoDecodeAccelerator(config.profile()).Pass();
+  if (!vda_ || !vda_->Initialize(this, config.profile())) {

[Ami GONE FROM CHROMIUM, 2014/02/25 00:01:35]

I love this formulation because it crystallizes so well my failure in making the
IPC & VDA interfaces symmetric by highlighting the repetition of the profile
parameter to CreateVDA & Initialize (the second of which is a no-op).
Oh well.

[sheu, 2014/02/25 00:37:16]

I don't think that's innately a failure -- it's more an IPC optimization, which
saves a round-trip by collapsing the construction and initialization.  That
optimization just has some uglier externally-visible effects.

[Ami GONE FROM CHROMIUM, 2014/02/25 00:50:51]

<MadTV>Lowered expectaaations...</MadTV>

     status_cb.Run(DECODER_ERROR_NOT_SUPPORTED);
     return;
   }
 
   DVLOG(3) << "GpuVideoDecoder::Initialize() succeeded.";
   media_log_->SetStringProperty("video_decoder", "gpu");
   status_cb.Run(PIPELINE_OK);
 }
 
 void GpuVideoDecoder::DestroyPictureBuffers(PictureBufferMap* buffers) {
@@ skipping 440 matching lines @@
     return;
   }
 }
 
 void GpuVideoDecoder::DCheckGpuVideoAcceleratorFactoriesTaskRunnerIsCurrent()
     const {
   DCHECK(factories_->GetTaskRunner()->BelongsToCurrentThread());
 }
 
 }  // namespace media