content/renderer/media/rtc_video_decoder.cc - Issue 170843004: Pass Client pointer in Initialize() for VDA/VEA

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/media/rtc_video_decoder.cc

Issue 170843004: Pass Client pointer in Initialize() for VDA/VEA (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: 48f212da fischman@ comments. Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/renderer/media/rtc_video_decoder.cc

diff --git a/content/renderer/media/rtc_video_decoder.cc b/content/renderer/media/rtc_video_decoder.cc

index ce1f24c6b520755daf9a58e07f2a2a7fd7265be7..bacbb9cd2a171429db52e9dce39402e412775001 100644

--- a/content/renderer/media/rtc_video_decoder.cc

+++ b/content/renderer/media/rtc_video_decoder.cc

@@ -672,7 +672,9 @@ void RTCVideoDecoder::ReusePictureBuffer(

void RTCVideoDecoder::CreateVDA(media::VideoCodecProfile profile,

base::WaitableEvent* waiter) {

DCHECK(vda_task_runner_->BelongsToCurrentThread());

- vda_ = factories_->CreateVideoDecodeAccelerator(profile, this);

+ vda_ = factories_->CreateVideoDecodeAccelerator(profile);

+ if (vda_ && !vda_->Initialize(this, profile))

+ vda_.release()->Destroy();

waiter->Signal();

}