Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(783)

Unified Diff: media/video/video_encode_accelerator.h

Issue 170843004: Pass Client pointer in Initialize() for VDA/VEA (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: b0ec4672 Build fixes. Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/video/video_encode_accelerator.h
diff --git a/media/video/video_encode_accelerator.h b/media/video/video_encode_accelerator.h
index f713d1754562ef5ed55fb88d3b814706e3a10ac3..0e7bb578d0031b0ac1c6b0aad998369b6d2251a8 100644
--- a/media/video/video_encode_accelerator.h
+++ b/media/video/video_encode_accelerator.h
@@ -97,6 +97,9 @@ class MEDIA_EXPORT VideoEncodeAccelerator {
// Initialize the video encoder with a specific configuration. Called once
// per encoder construction.
// Parameters:
+ // |client| is the client of this video encoder. The provided pointer must
+ // be valid for the rest of the lifetime of this encoder, until Destroy()
Ami GONE FROM CHROMIUM 2014/02/24 23:12:40 ditto drop "for the rest of the lifetime of this e
sheu 2014/02/24 23:48:20 Done.
+ // is called.
// |input_format| is the frame format of the input stream (as would be
// reported by VideoFrame::format() for frames passed to Encode()).
// |input_visible_size| is the resolution of the input stream (as would be
@@ -106,7 +109,8 @@ class MEDIA_EXPORT VideoEncodeAccelerator {
// |initial_bitrate| is the initial bitrate of the encoded output stream,
// in bits per second.
// TODO(sheu): handle resolution changes. http://crbug.com/249944
- virtual void Initialize(media::VideoFrame::Format input_format,
+ virtual void Initialize(Client* client,
+ media::VideoFrame::Format input_format,
scherkus (not reviewing) 2014/02/20 18:52:09 nit: remove media:: ?
sheu 2014/02/24 23:48:20 Done.
const gfx::Size& input_visible_size,
VideoCodecProfile output_profile,
uint32 initial_bitrate) = 0;
« media/video/video_decode_accelerator.h ('K') | « media/video/video_decode_accelerator.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698