Pass Client pointer in Initialize() for VDA/VEA

media/video/video_encode_accelerator.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef MEDIA_VIDEO_VIDEO_ENCODE_ACCELERATOR_H_
 #define MEDIA_VIDEO_VIDEO_ENCODE_ACCELERATOR_H_
 
 #include <vector>
 
 #include "base/basictypes.h"
@@ skipping 79 matching lines @@
     // Clients are not owned by VEA instances and should not be deleted through
     // these pointers.
     virtual ~Client() {}
   };
 
   // Video encoder functions.
 
   // Initialize the video encoder with a specific configuration.  Called once
   // per encoder construction.
   // Parameters:
+  //  |client| is the client of this video encoder.  The provided pointer must
+  //  be valid for the rest of the lifetime of this encoder, until Destroy()

[Ami GONE FROM CHROMIUM, 2014/02/24 23:12:40]

ditto drop "for the rest of the lifetime of this encoder, "

[sheu, 2014/02/24 23:48:20]

Done.

+  //  is called.
   //  |input_format| is the frame format of the input stream (as would be
   //  reported by VideoFrame::format() for frames passed to Encode()).
   //  |input_visible_size| is the resolution of the input stream (as would be
   //  reported by VideoFrame::visible_rect().size() for frames passed to
   //  Encode()).
   //  |output_profile| is the codec profile of the encoded output stream.
   //  |initial_bitrate| is the initial bitrate of the encoded output stream,
   //  in bits per second.
   // TODO(sheu): handle resolution changes.  http://crbug.com/249944
-  virtual void Initialize(media::VideoFrame::Format input_format,
+  virtual void Initialize(Client* client,
+                          media::VideoFrame::Format input_format,

[scherkus (not reviewing), 2014/02/20 18:52:09]

nit: remove media:: ?

[sheu, 2014/02/24 23:48:20]

Done.

                           const gfx::Size& input_visible_size,
                           VideoCodecProfile output_profile,
                           uint32 initial_bitrate) = 0;
 
   // Encodes the given frame.
   // Parameters:
   //  |frame| is the VideoFrame that is to be encoded.
   //  |force_keyframe| forces the encoding of a keyframe for this frame.
   virtual void Encode(const scoped_refptr<VideoFrame>& frame,
                       bool force_keyframe) = 0;
@@ skipping 17 matching lines @@
   // immediately and the component is freed.  This call may asynchronously free
   // system resources, but its client-visible effects are synchronous.  After
   // this method returns no more callbacks will be made on the client.  Deletes
   // |this| unconditionally, so make sure to drop all pointers to it!
   virtual void Destroy() = 0;
 };
 
 }  // namespace media
 
 #endif  // MEDIA_VIDEO_VIDEO_ENCODE_ACCELERATOR_H_