Pass Client pointer in Initialize() for VDA/VEA

media/video/video_decode_accelerator.h

Index: media/video/video_decode_accelerator.h
diff --git a/media/video/video_decode_accelerator.h b/media/video/video_decode_accelerator.h
index 5212db2c48812bd31d456d2dbf7b65a1447c50ea..67a8af1397ecc743d5db4ce4644cf79a58ae2d81 100644
--- a/media/video/video_decode_accelerator.h
+++ b/media/video/video_decode_accelerator.h
@@ -85,10 +85,13 @@ class MEDIA_EXPORT VideoDecodeAccelerator
 
   // Initializes the video decoder with specific configuration.
   // Parameters:
+  //  |client| is the client of this video decoder.  The provided pointer must
+  //  be valid for the rest of the lifetime of this decoder, until Destroy()

[Ami GONE FROM CHROMIUM, 2014/02/24 23:12:40]

I'd drop "for the rest of the lifetime of this decoder, " since the final clause
is more precise and useful.

[sheu, 2014/02/24 23:48:20]

Done.

+  //  is called.
   //  |profile| is the video stream's format profile.
   //
   // Returns true when command successfully accepted. Otherwise false.
-  virtual bool Initialize(VideoCodecProfile profile) = 0;
+  virtual bool Initialize(Client* client, VideoCodecProfile profile) = 0;

[Ami GONE FROM CHROMIUM, 2014/02/24 23:12:40]

In-params usually precede out-params, and POD params are innier than params that
will get methods invoked on them in the future (which seems closer to out-param
than in-param to me) so if it was me I'd make |client| the last param here (and
ditto in vea.h).  But that'd mean touching a lot of files in this CL so I'm not
going to insist...

[sheu, 2014/02/24 23:48:20]

My feeling is that |client| is more innate to the state of the VDA/VEA than
|profile|, since the client is essentially the parent of this whole object.  Yay
feelings.

I'd rather fix it once in this CL than not bother and then have it bother over
and over again people whenever they see the code.  So if you really think the
other ordering is better I'll just make a pass and do it.  Just let me know.

[Ami GONE FROM CHROMIUM, 2014/02/25 00:01:35]

Yeah, I definitely think profile should come first.

 
   // Decodes given bitstream buffer that contains at most one frame. Once
   // decoder is done with processing |bitstream_buffer| it will call