Pass Client pointer in Initialize() for VDA/VEA

media/video/video_decode_accelerator.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef MEDIA_VIDEO_VIDEO_DECODE_ACCELERATOR_H_
 #define MEDIA_VIDEO_VIDEO_DECODE_ACCELERATOR_H_
 
 #include <vector>
 
 #include "base/basictypes.h"
@@ skipping 67 matching lines @@
     virtual void NotifyError(Error error) = 0;
 
    protected:
     virtual ~Client() {}
   };
 
   // Video decoder functions.
 
   // Initializes the video decoder with specific configuration.
   // Parameters:
+  //  |client| is the client of this video decoder.  The provided pointer must
+  //  be valid for the rest of the lifetime of this decoder, until Destroy()

[Ami GONE FROM CHROMIUM, 2014/02/24 23:12:40]

I'd drop "for the rest of the lifetime of this decoder, " since the final clause
is more precise and useful.

[sheu, 2014/02/24 23:48:20]

Done.

+  //  is called.
   //  |profile| is the video stream's format profile.
   //
   // Returns true when command successfully accepted. Otherwise false.
-  virtual bool Initialize(VideoCodecProfile profile) = 0;
+  virtual bool Initialize(Client* client, VideoCodecProfile profile) = 0;

[Ami GONE FROM CHROMIUM, 2014/02/24 23:12:40]

In-params usually precede out-params, and POD params are innier than params that
will get methods invoked on them in the future (which seems closer to out-param
than in-param to me) so if it was me I'd make |client| the last param here (and
ditto in vea.h).  But that'd mean touching a lot of files in this CL so I'm not
going to insist...

[sheu, 2014/02/24 23:48:20]

My feeling is that |client| is more innate to the state of the VDA/VEA than
|profile|, since the client is essentially the parent of this whole object.  Yay
feelings.

I'd rather fix it once in this CL than not bother and then have it bother over
and over again people whenever they see the code.  So if you really think the
other ordering is better I'll just make a pass and do it.  Just let me know.

[Ami GONE FROM CHROMIUM, 2014/02/25 00:01:35]

Yeah, I definitely think profile should come first.

 
   // Decodes given bitstream buffer that contains at most one frame. Once
   // decoder is done with processing |bitstream_buffer| it will call
   // NotifyEndOfBitstreamBuffer() with the bitstream buffer id.
   // Parameters:
   //  |bitstream_buffer| is the input bitstream that is sent for decoding.
   virtual void Decode(const BitstreamBuffer& bitstream_buffer) = 0;
 
   // Assigns a set of texture-backed picture buffers to the video decoder.
   //
@@ skipping 29 matching lines @@
   // component is freed.  This call may asynchornously free system resources,
   // but its client-visible effects are synchronous.  After this method returns
   // no more callbacks will be made on the client.  Deletes |this|
   // unconditionally, so make sure to drop all pointers to it!
   virtual void Destroy() = 0;
 };
 
 }  // namespace media
 
 #endif  // MEDIA_VIDEO_VIDEO_DECODE_ACCELERATOR_H_