Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(63)

Issue 17074007: Remove ActiveDesktopMonitor from DesktopNotificationsUnittests (Closed)

Created:
7 years, 6 months ago by gab
Modified:
7 years, 6 months ago
Reviewers:
Dmitry Titov, scottmg
CC:
chromium-reviews
Visibility:
Public.

Description

Remove ActiveDesktopMonitor from DesktopNotificationsUnittests An ActiveDesktopMonitor is actually not necessary here I believe (a window is never activated so the monitor simply returns the default host desktop type (which is the same as the type returned when there is no monitor). BUG=179830 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=208051

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -5 lines) Patch
M chrome/browser/notifications/desktop_notifications_unittest.h View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/notifications/desktop_notifications_unittest.cc View 3 chunks +0 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
gab
Scott, you originally added this in https://chromiumcodereview.appspot.com/11416145, I don't think it's required anymore (and I'm ...
7 years, 6 months ago (2013-06-21 20:11:40 UTC) #1
scottmg
if it works for all aura configs, lgtm
7 years, 6 months ago (2013-06-21 20:13:36 UTC) #2
Dmitry Titov
lgtm too if all the bots are happy :-)
7 years, 6 months ago (2013-06-21 20:30:59 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gab@chromium.org/17074007/1
7 years, 6 months ago (2013-06-21 20:33:32 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gab@chromium.org/17074007/1
7 years, 6 months ago (2013-06-22 02:34:21 UTC) #5
commit-bot: I haz the power
7 years, 6 months ago (2013-06-22 15:01:31 UTC) #6
Message was sent while issue was closed.
Change committed as 208051

Powered by Google App Engine
This is Rietveld 408576698