Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(65)

Issue 11416145: desktop notification test setup: valid ShellDelegate, create ActiveDesktopMonitor (Closed)

Created:
8 years, 1 month ago by scottmg
Modified:
8 years, 1 month ago
CC:
chromium-reviews
Visibility:
Public.

Description

desktop notification test setup: valid ShellDelegate, create ActiveDesktopMonitor Two fixes for DesktopNotificationTest.* on win_aura: - was creating a ShellInstance with a NULL delegate which Shell DCHECKs on: pull in ash::test::TestShellDelegate - wasn't creating an ActiveDesktopMonitor, so instantiate one for test purposes. Also, change a couple USE_AURAs that look like they should be USE_ASHs. R=grt@chromium.org, stevenjb@chromium.org TEST=browser_tests on win_aura, DesktopNotificationTest.* Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=169181

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -3 lines) Patch
M chrome/browser/notifications/desktop_notifications_unittest.h View 2 chunks +4 lines, -1 line 0 comments Download
M chrome/browser/notifications/desktop_notifications_unittest.cc View 3 chunks +6 lines, -2 lines 0 comments Download
M chrome/chrome_tests.gypi View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
scottmg
8 years, 1 month ago (2012-11-21 21:33:03 UTC) #1
stevenjb
lgtm
8 years, 1 month ago (2012-11-21 21:52:42 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scottmg@chromium.org/11416145/1
8 years, 1 month ago (2012-11-21 23:04:31 UTC) #3
commit-bot: I haz the power
Change committed as 169181
8 years, 1 month ago (2012-11-22 01:03:38 UTC) #4
grt (UTC plus 2)
8 years, 1 month ago (2012-11-22 02:55:38 UTC) #5
lgtm+1.  thanks.

Powered by Google App Engine
This is Rietveld 408576698