Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(311)

Issue 17064004: remove all old style callbacks - patch 1 of many (Closed)

Created:
7 years, 6 months ago by dcarney
Modified:
7 years, 6 months ago
Reviewers:
Sven Panne
CC:
v8-dev
Visibility:
Public.

Description

remove all old style callbacks - patch 1 of many R=svenpanne@chromium.org BUG= Committed: https://code.google.com/p/v8/source/detail?r=15222

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+278 lines, -354 lines) Patch
M test/cctest/test-accessors.cc View 14 chunks +43 lines, -40 lines 0 comments Download
M test/cctest/test-api.cc View 67 chunks +235 lines, -314 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
dcarney
this is needed to enable deprecation of old callbacks, which we can do now
7 years, 6 months ago (2013-06-14 12:00:18 UTC) #1
Sven Panne
lgtm
7 years, 6 months ago (2013-06-18 07:03:11 UTC) #2
dcarney
7 years, 6 months ago (2013-06-20 08:13:06 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r15222 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698