Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1400)

Unified Diff: chrome/browser/media/webrtc_log_upload_list.h

Issue 17063004: Adding WebRTC log upload list under chrome://webrtc-logs (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fixed HTML, JS and CSS files. Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/media/webrtc_log_upload_list.h
diff --git a/chrome/browser/media/webrtc_log_upload_list.h b/chrome/browser/media/webrtc_log_upload_list.h
new file mode 100644
index 0000000000000000000000000000000000000000..73da8fe8a3c115bb8fcaa96d1219b1cc45b82b32
--- /dev/null
+++ b/chrome/browser/media/webrtc_log_upload_list.h
@@ -0,0 +1,29 @@
+// Copyright 2013 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROME_BROWSER_MEDIA_WEBRTC_LOG_UPLOAD_LIST_H_
+#define CHROME_BROWSER_MEDIA_WEBRTC_LOG_UPLOAD_LIST_H_
+
+#include "chrome/browser/upload_list.h"
+
+class WebRtcLogUploadList : public UploadList {
James Hawkins 2013/06/24 15:05:07 nit: Document class.
Henrik Grunell 2013/06/24 17:11:44 Done.
+ public:
+ // Static factory method that creates the WebRTC log upload list with the
James Hawkins 2013/06/24 15:05:07 Optional nit: "Static factory method that" is supe
Henrik Grunell 2013/06/24 17:11:44 Done.
+ // given callback delegate.
+ static WebRtcLogUploadList* Create(Delegate* delegate);
+
+ static const char* kWebRtcLogListFilename;
James Hawkins 2013/06/24 15:05:07 Why is this public? Documentation would help.
Henrik Grunell 2013/06/24 17:11:44 Done.
+
+ // Creates a new WebRTC log upload list with the given callback delegate.
+ explicit WebRtcLogUploadList(Delegate* delegate,
+ const base::FilePath& upload_log_path);
James Hawkins 2013/06/24 15:05:07 nit: Document |upload_log_path|.
Henrik Grunell 2013/06/24 17:11:44 Done.
+
+ protected:
+ virtual ~WebRtcLogUploadList();
+
+ private:
+ DISALLOW_COPY_AND_ASSIGN(WebRtcLogUploadList);
+};
+
+#endif // CHROME_BROWSER_MEDIA_WEBRTC_LOG_UPLOAD_LIST_H_

Powered by Google App Engine
This is Rietveld 408576698