Adding WebRTC log upload list under chrome://webrtc-logs

chrome/browser/media/webrtc_log_upload_list.h

+// Copyright 2013 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROME_BROWSER_MEDIA_WEBRTC_LOG_UPLOAD_LIST_H_
+#define CHROME_BROWSER_MEDIA_WEBRTC_LOG_UPLOAD_LIST_H_
+
+#include "chrome/browser/upload_list.h"
+
+class WebRtcLogUploadList : public UploadList {

[James Hawkins, 2013/06/24 15:05:07]

nit: Document class.

[Henrik Grunell, 2013/06/24 17:11:44]

Done.

+ public:
+  // Static factory method that creates the WebRTC log upload list with the

[James Hawkins, 2013/06/24 15:05:07]

Optional nit: "Static factory method that" is superfluous.

[Henrik Grunell, 2013/06/24 17:11:44]

Done.

+  // given callback delegate.
+  static WebRtcLogUploadList* Create(Delegate* delegate);
+
+  static const char* kWebRtcLogListFilename;

[James Hawkins, 2013/06/24 15:05:07]

Why is this public?  Documentation would help.

[Henrik Grunell, 2013/06/24 17:11:44]

Done.

+
+  // Creates a new WebRTC log upload list with the given callback delegate.
+  explicit WebRtcLogUploadList(Delegate* delegate,
+                               const base::FilePath& upload_log_path);

[James Hawkins, 2013/06/24 15:05:07]

nit: Document |upload_log_path|.

[Henrik Grunell, 2013/06/24 17:11:44]

Done.

+
+ protected:
+  virtual ~WebRtcLogUploadList();
+
+ private:
+  DISALLOW_COPY_AND_ASSIGN(WebRtcLogUploadList);
+};
+
+#endif  // CHROME_BROWSER_MEDIA_WEBRTC_LOG_UPLOAD_LIST_H_