Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issue 17029002: Change the permission check for Pepper socket API to support both the public and private APIs. (Closed)

Created:
7 years, 6 months ago by yzshen1
Modified:
7 years, 6 months ago
Reviewers:
jam, joth, victorhsieh, Bei Zhang
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, android-webview-reviews_chromium.org, dmichael (off chromium), bbudge
Visibility:
Public.

Description

Change the permission check for Pepper socket API to support both the public and private APIs. BUG=247225 TEST=None Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=206533

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+90 lines, -32 lines) Patch
M android_webview/browser/aw_content_browser_client.h View 1 chunk +1 line, -0 lines 0 comments Download
M android_webview/browser/aw_content_browser_client.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/chrome_content_browser_client.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/chrome_content_browser_client.cc View 3 chunks +28 lines, -4 lines 0 comments Download
M chrome/browser/renderer_host/pepper/pepper_crx_file_system_message_filter.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/common/pepper_permission_util.h View 1 chunk +11 lines, -4 lines 0 comments Download
M chrome/common/pepper_permission_util.cc View 2 chunks +25 lines, -13 lines 0 comments Download
M chrome/renderer/chrome_content_renderer_client.cc View 1 chunk +7 lines, -5 lines 0 comments Download
M content/browser/renderer_host/pepper/pepper_host_resolver_private_message_filter.cc View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/renderer_host/pepper/pepper_message_filter.cc View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/renderer_host/pepper/pepper_socket_utils.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/renderer_host/pepper/pepper_socket_utils.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M content/browser/renderer_host/pepper/pepper_udp_socket_private_message_filter.cc View 1 chunk +1 line, -0 lines 0 comments Download
M content/public/browser/content_browser_client.h View 1 chunk +5 lines, -2 lines 0 comments Download
M content/public/browser/content_browser_client.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
yzshen1
Hi, Would you please take a look? John: The changes to the content API: content/public/browser/content_browser_client.{h,cc} ...
7 years, 6 months ago (2013-06-13 23:54:03 UTC) #1
jam
On 2013/06/13 23:54:03, yzshen1 wrote: > Hi, > > Would you please take a look? ...
7 years, 6 months ago (2013-06-14 00:20:08 UTC) #2
victorhsieh
lgtm
7 years, 6 months ago (2013-06-14 15:22:07 UTC) #3
yzshen1
Hi, Jonathan. Would you please do an OWNER review for: android_webview/browser/aw_content_browser_client.{h,cc} Thanks!
7 years, 6 months ago (2013-06-14 16:28:13 UTC) #4
joth
lgtm
7 years, 6 months ago (2013-06-14 18:27:56 UTC) #5
Bei Zhang
lgtm
7 years, 6 months ago (2013-06-14 18:31:16 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yzshen@chromium.org/17029002/1
7 years, 6 months ago (2013-06-14 18:38:55 UTC) #7
commit-bot: I haz the power
Retried try job too often on win7_aura for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win7_aura&number=50396
7 years, 6 months ago (2013-06-14 23:14:13 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yzshen@chromium.org/17029002/1
7 years, 6 months ago (2013-06-14 23:17:26 UTC) #9
commit-bot: I haz the power
7 years, 6 months ago (2013-06-15 01:26:41 UTC) #10
Message was sent while issue was closed.
Change committed as 206533

Powered by Google App Engine
This is Rietveld 408576698