content/browser/renderer_host/pepper/pepper_socket_utils.cc - Issue 17029002: Change the permission check for Pepper socket API to support both the public and private APIs.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/pepper/pepper_socket_utils.cc

Issue 17029002: Change the permission check for Pepper socket API to support both the public and private APIs. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/renderer_host/pepper/pepper_socket_utils.h ('k') | content/browser/renderer_host/pepper/pepper_udp_socket_private_message_filter.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/renderer_host/pepper/pepper_socket_utils.cc

diff --git a/content/browser/renderer_host/pepper/pepper_socket_utils.cc b/content/browser/renderer_host/pepper/pepper_socket_utils.cc

index 69e6ddc236303fc54c2fc6622da40e426dfe8174..60a07e77b46c0a4fcb11e7e282f8f860bc911e4f 100644

--- a/content/browser/renderer_host/pepper/pepper_socket_utils.cc

+++ b/content/browser/renderer_host/pepper/pepper_socket_utils.cc

@@ -33,6 +33,7 @@ SocketPermissionRequest CreateSocketPermissionRequest(

}

bool CanUseSocketAPIs(bool external_plugin,

+ bool private_api,

const SocketPermissionRequest& params,

RenderViewHost* render_view_host) {

DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));

@@ -52,6 +53,7 @@ bool CanUseSocketAPIs(bool external_plugin,

if (!GetContentClient()->browser()->AllowPepperSocketAPI(

site_instance->GetBrowserContext(),

site_instance->GetSiteURL(),

+ private_api,

params)) {

LOG(ERROR) << "Host " << site_instance->GetSiteURL().host()

<< " cannot use socket API or destination is not allowed";