[win/cros/lin] Update spellcheck menu strings according to UX.

[spellcheck] Update spellcheck menu strings according to UX.

Mac:

"Language Settings..." -> "Language Settings"

Win/CrOS/Lin:

"Spellcheck..." -> "Spellcheck"
"All languages" -> "All your languages"
"Settings..."   -> "Language settings"

Also, remove the string "This language is used for spellchecking,"
because it is no longer used. It has been superseded by "Use this
language for spellcheck" checkbox in chrome://settings/languages.

BUG=544234
Committed: https://crrev.com/513c6165e484bba6ffd78eea29e8935ce2529394
Cr-Commit-Position: refs/heads/master@{#376569}

[please use gerrit instead, 2016-02-17 02:05:04]

Patchset #1 (id:1) has been deleted

[please use gerrit instead, 2016-02-17 02:05:49]

rouslan@chromium.org changed reviewers:
+ groby@chromium.org

[please use gerrit instead, 2016-02-17 02:05:49]

Rachel, ptal.

[please use gerrit instead, 2016-02-17 02:28:55]

Description was changed from

==========
[win/cros/lin] Update spellcheck menu strings according to UX.

"Spellcheck..." -> "Spellcheck"
"Settings..."   -> "Language settings"

Also, remove the string "This language is used for spellchecking,"
because it is no longer used. It has been superseded by "Use this
language for spellcheck" checkbox in chrome://settings/languages.

BUG=544234
==========

to

==========
[spellcheck] Update spellcheck menu strings according to UX.

Mac:

"Language Settings..." -> "Language Settings"

Win/CrOS/Lin:

"Spellcheck..." -> "Spellcheck"
"Settings..."   -> "Language settings"

Also, remove the string "This language is used for spellchecking,"
because it is no longer used. It has been superseded by "Use this
language for spellcheck" checkbox in chrome://settings/languages.

BUG=544234
==========

[groby-ooo-7-16, 2016-02-18 03:06:36]

Messages look lovely, but I think there's a dangling reference.

https://codereview.chromium.org/1700373003/diff/40001/chrome/browser/ui/webui...
File chrome/browser/ui/webui/options/language_options_handler_common.cc (left):

https://codereview.chromium.org/1700373003/diff/40001/chrome/browser/ui/webui...
chrome/browser/ui/webui/options/language_options_handler_common.cc:84:
IDS_OPTIONS_SETTINGS_IS_USED_FOR_SPELL_CHECKING },
Uh, isn't that still used?
https://code.google.com/p/chromium/codesearch#chromium/src/chrome/browser/res...

[please use gerrit instead, 2016-02-18 16:54:30]

https://codereview.chromium.org/1700373003/diff/40001/chrome/browser/ui/webui...
File chrome/browser/ui/webui/options/language_options_handler_common.cc (left):

https://codereview.chromium.org/1700373003/diff/40001/chrome/browser/ui/webui...
chrome/browser/ui/webui/options/language_options_handler_common.cc:84:
IDS_OPTIONS_SETTINGS_IS_USED_FOR_SPELL_CHECKING },
On 2016/02/18 03:06:36, groby wrote:
> Uh, isn't that still used?
>
https://code.google.com/p/chromium/codesearch#chromium/src/chrome/browser/res...

Bad naming in language_options.js. The variable "isUsedForSpellChecking" that
you see in there is a local that's declared a few lines above:

    var isUsedForSpellchecking = languageCode in this.spellCheckLanguages_;

      spellCheckLanguageCheckbox.languageCode = languageCode;
      spellCheckLanguageCheckbox.checked = isUsedForSpellchecking;

The variable defined here in language_options_handler_common.cc can be accessed
in JavaScript only through loadTimeData.getString('isUsedForSpellchecking') and
in HTML through <span i18n-content="isUsedForSpellchecking"></span>. These do
not exist after single language spellcheck was deprecated.

[please use gerrit instead, 2016-02-18 17:35:08]

rouslan@chromium.org changed reviewers:
+ dbeam@chromium.org

[please use gerrit instead, 2016-02-18 17:35:09]

Dan, owners ptal language_options_handler_common.cc in patch 3.

[Dan Beam, 2016-02-18 18:41:04]

lgtm

[please use gerrit instead, 2016-02-19 20:36:44]

Rachel, ping patch 3.

[please use gerrit instead, 2016-02-19 20:39:20]

Description was changed from

==========
[spellcheck] Update spellcheck menu strings according to UX.

Mac:

"Language Settings..." -> "Language Settings"

Win/CrOS/Lin:

"Spellcheck..." -> "Spellcheck"
"Settings..."   -> "Language settings"

Also, remove the string "This language is used for spellchecking,"
because it is no longer used. It has been superseded by "Use this
language for spellcheck" checkbox in chrome://settings/languages.

BUG=544234
==========

to

==========
[spellcheck] Update spellcheck menu strings according to UX.

Mac:

"Language Settings..." -> "Language Settings"

Win/CrOS/Lin:

"Spellcheck..." -> "Spellcheck"
"All languages" -> "All your languages"
"Settings..."   -> "Language settings"

Also, remove the string "This language is used for spellchecking,"
because it is no longer used. It has been superseded by "Use this
language for spellcheck" checkbox in chrome://settings/languages.

BUG=544234
==========

[groby-ooo-7-16, 2016-02-19 21:38:07]

Still lovely messages. LGTM :)

[please use gerrit instead, 2016-02-19 21:48:34]

The CQ bit was checked by rouslan@chromium.org

[commit-bot: I haz the power, 2016-02-19 21:51:28]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1700373003/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1700373003/60001

[commit-bot: I haz the power, 2016-02-19 23:28:06]

Description was changed from

==========
[spellcheck] Update spellcheck menu strings according to UX.

Mac:

"Language Settings..." -> "Language Settings"

Win/CrOS/Lin:

"Spellcheck..." -> "Spellcheck"
"All languages" -> "All your languages"
"Settings..."   -> "Language settings"

Also, remove the string "This language is used for spellchecking,"
because it is no longer used. It has been superseded by "Use this
language for spellcheck" checkbox in chrome://settings/languages.

BUG=544234
==========

to

==========
[spellcheck] Update spellcheck menu strings according to UX.

Mac:

"Language Settings..." -> "Language Settings"

Win/CrOS/Lin:

"Spellcheck..." -> "Spellcheck"
"All languages" -> "All your languages"
"Settings..."   -> "Language settings"

Also, remove the string "This language is used for spellchecking,"
because it is no longer used. It has been superseded by "Use this
language for spellcheck" checkbox in chrome://settings/languages.

BUG=544234
==========

[commit-bot: I haz the power, 2016-02-19 23:28:07]

Committed patchset #3 (id:60001)

[commit-bot: I haz the power, 2016-02-19 23:29:23]

Description was changed from

==========
[spellcheck] Update spellcheck menu strings according to UX.

Mac:

"Language Settings..." -> "Language Settings"

Win/CrOS/Lin:

"Spellcheck..." -> "Spellcheck"
"All languages" -> "All your languages"
"Settings..."   -> "Language settings"

Also, remove the string "This language is used for spellchecking,"
because it is no longer used. It has been superseded by "Use this
language for spellcheck" checkbox in chrome://settings/languages.

BUG=544234
==========

to

==========
[spellcheck] Update spellcheck menu strings according to UX.

Mac:

"Language Settings..." -> "Language Settings"

Win/CrOS/Lin:

"Spellcheck..." -> "Spellcheck"
"All languages" -> "All your languages"
"Settings..."   -> "Language settings"

Also, remove the string "This language is used for spellchecking,"
because it is no longer used. It has been superseded by "Use this
language for spellcheck" checkbox in chrome://settings/languages.

BUG=544234

Committed: https://crrev.com/513c6165e484bba6ffd78eea29e8935ce2529394
Cr-Commit-Position: refs/heads/master@{#376569}
==========

[commit-bot: I haz the power, 2016-02-19 23:29:24]

Patchset 3 (id:??) landed as
https://crrev.com/513c6165e484bba6ffd78eea29e8935ce2529394
Cr-Commit-Position: refs/heads/master@{#376569}