LayoutTests/media/track/track-disabled.html - Issue 17002002: TextTrackCue should check for non-NULL cue list pointer

Unified Diff: LayoutTests/media/track/track-disabled.html

Issue 17002002: TextTrackCue should check for non-NULL cue list pointer (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: added webkit layout test Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: LayoutTests/media/track/track-disabled.html

diff --git a/LayoutTests/media/track/track-disabled.html b/LayoutTests/media/track/track-disabled.html

new file mode 100644

index 0000000000000000000000000000000000000000..f17dc0ca55fbc263785fadd5c70701417fe07ae2

--- /dev/null

+++ b/LayoutTests/media/track/track-disabled.html

@@ -0,0 +1,27 @@

+<!DOCTYPE html>

+<html>

+<script src=../media-file.js></script>

acolwell GONE FROM CHROMIUM 2013/06/27 21:45:20 nit: script tags should be inside <head> and tags

Matthew Heaney (Chromium) 2013/06/27 23:25:10 OK, thanks for the info. I was trying to infer th

acolwell GONE FROM CHROMIUM 2013/06/27 23:51:53 Yeah. Unfortunately the style isn't consistent acr

+<script src=../video-test.js></script>

+<script>

+ if (window.testRunner)

+ testRunner.dumpAsText();

acolwell GONE FROM CHROMIUM 2013/06/27 21:45:20 nit: Needs 4 space indent.

Matthew Heaney (Chromium) 2013/06/27 23:25:10 Done.

+ waitForEvent('loadstart',

acolwell GONE FROM CHROMIUM 2013/06/27 21:45:20 nit: The following is more inline with WebKit styl

Matthew Heaney (Chromium) 2013/06/27 23:25:10 Done.

+ function () {

+ var v = document.getElementById('vid');

+ v.textTracks[0].mode = "disabled";

+ }

+ );

acolwell GONE FROM CHROMIUM 2013/06/27 21:45:20 You should probably waitForEventAndEnd('loadedmeta

Matthew Heaney (Chromium) 2013/06/27 23:25:10 Done.

+</script>

+<body>

+ <video id="vid" src="../content/test.mp4" autoplay controls>

acolwell GONE FROM CHROMIUM 2013/06/27 21:45:20 nit: I'm pretty sure you need to use test.ogv here

Matthew Heaney (Chromium) 2013/06/27 23:25:10 Done.

+ <track kind='subtitles' srclang='en' label='English' src='captions-webvtt/captions.vtt' />

+ </video>

+</body>

+</html>

« no previous file with comments | « no previous file | LayoutTests/media/track/track-disabled-expected.html » ('j') | LayoutTests/media/track/track-disabled-expected.html » ('J')