Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(236)

Side by Side Diff: LayoutTests/media/track/track-disabled.html

Issue 17002002: TextTrackCue should check for non-NULL cue list pointer (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: added webkit layout test Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
(Empty)
1 <!DOCTYPE html>
2 <html>
3
4 <script src=../media-file.js></script>
acolwell GONE FROM CHROMIUM 2013/06/27 21:45:20 nit: script tags should be inside <head> and tags
Matthew Heaney (Chromium) 2013/06/27 23:25:10 OK, thanks for the info. I was trying to infer th
acolwell GONE FROM CHROMIUM 2013/06/27 23:51:53 Yeah. Unfortunately the style isn't consistent acr
5 <script src=../video-test.js></script>
6
7 <script>
8
9 if (window.testRunner)
10 testRunner.dumpAsText();
acolwell GONE FROM CHROMIUM 2013/06/27 21:45:20 nit: Needs 4 space indent.
Matthew Heaney (Chromium) 2013/06/27 23:25:10 Done.
11
12 waitForEvent('loadstart',
acolwell GONE FROM CHROMIUM 2013/06/27 21:45:20 nit: The following is more inline with WebKit styl
Matthew Heaney (Chromium) 2013/06/27 23:25:10 Done.
13 function () {
14 var v = document.getElementById('vid');
15 v.textTracks[0].mode = "disabled";
16 }
17 );
18
acolwell GONE FROM CHROMIUM 2013/06/27 21:45:20 You should probably waitForEventAndEnd('loadedmeta
Matthew Heaney (Chromium) 2013/06/27 23:25:10 Done.
19 </script>
20
21 <body>
22 <video id="vid" src="../content/test.mp4" autoplay controls>
acolwell GONE FROM CHROMIUM 2013/06/27 21:45:20 nit: I'm pretty sure you need to use test.ogv here
Matthew Heaney (Chromium) 2013/06/27 23:25:10 Done.
23 <track kind='subtitles' srclang='en' label='English' src='captions-webvtt/ca ptions.vtt' />
24 </video>
25 </body>
26
27 </html>
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698