LayoutTests/media/track/track-disabled.html - Issue 17002002: TextTrackCue should check for non-NULL cue list pointer

Side by Side Diff: LayoutTests/media/track/track-disabled.html

Issue 17002002: TextTrackCue should check for non-NULL cue list pointer (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: added webkit layout test Created 7 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <html>

	3

	4 <script src=../media-file.js></script>
	acolwell GONE FROM CHROMIUM 2013/06/27 21:45:20 nit: script tags should be inside <head> and tags nit: script tags should be inside <head> and tags should have 4 space indentation. Matthew Heaney (Chromium) 2013/06/27 23:25:10 OK, thanks for the info. I was trying to infer th Show quoted text On 2013/06/27 21:45:20, acolwell wrote: > nit: script tags should be inside <head> and tags should have 4 space > indentation. OK, thanks for the info. I was trying to infer the style rules, but many of these test files seem to use different conventions. acolwell GONE FROM CHROMIUM 2013/06/27 23:51:53 Yeah. Unfortunately the style isn't consistent acr Show quoted text On 2013/06/27 23:25:10, Matthew Heaney (Chromium) wrote: > On 2013/06/27 21:45:20, acolwell wrote: > > nit: script tags should be inside <head> and tags should have 4 space > > indentation. > > OK, thanks for the info. I was trying to infer the style rules, but many of > these test files seem to use different conventions. Yeah. Unfortunately the style isn't consistent across a lot of the media LayoutTests because of different bars set by different reviewers in the WebKit days.
	5 <script src=../video-test.js></script>

	6

	7 <script>

	8

	9 if (window.testRunner)

	10 testRunner.dumpAsText();
	acolwell GONE FROM CHROMIUM 2013/06/27 21:45:20 nit: Needs 4 space indent. nit: Needs 4 space indent. Matthew Heaney (Chromium) 2013/06/27 23:25:10 Done. Show quoted text On 2013/06/27 21:45:20, acolwell wrote: > nit: Needs 4 space indent. Done.
	11

	12 waitForEvent('loadstart',
	acolwell GONE FROM CHROMIUM 2013/06/27 21:45:20 nit: The following is more inline with WebKit styl nit: The following is more inline with WebKit style. waitForEvent('loadstart', function () { var v = document.getElementById('vid'); v.textTracks[0].mode = "disabled"; }); Matthew Heaney (Chromium) 2013/06/27 23:25:10 Done. Show quoted text On 2013/06/27 21:45:20, acolwell wrote: > nit: The following is more inline with WebKit style. > waitForEvent('loadstart', function () > { > var v = document.getElementById('vid'); > v.textTracks[0].mode = "disabled"; > }); Done.
	13 function () {

	14 var v = document.getElementById('vid');

	15 v.textTracks[0].mode = "disabled";

	16 }

	17 );

	18
	acolwell GONE FROM CHROMIUM 2013/06/27 21:45:20 You should probably waitForEventAndEnd('loadedmeta You should probably waitForEventAndEnd('loadedmetadata') here so that the test ends when we reach the HAVE_METADATA state. I'm assuming the crash happens sometime after the loadstart event handler returns. Matthew Heaney (Chromium) 2013/06/27 23:25:10 Done. Show quoted text On 2013/06/27 21:45:20, acolwell wrote: > You should probably waitForEventAndEnd('loadedmetadata') here so that the test > ends when we reach the HAVE_METADATA state. I'm assuming the crash happens > sometime after the loadstart event handler returns. Done.
	19 </script>

	20

	21 <body>

	22 <video id="vid" src="../content/test.mp4" autoplay controls>
	acolwell GONE FROM CHROMIUM 2013/06/27 21:45:20 nit: I'm pretty sure you need to use test.ogv here nit: I'm pretty sure you need to use test.ogv here since Chromium builds don't have MP4 support turned on by default. Matthew Heaney (Chromium) 2013/06/27 23:25:10 Done. Show quoted text On 2013/06/27 21:45:20, acolwell wrote: > nit: I'm pretty sure you need to use test.ogv here since Chromium builds don't > have MP4 support turned on by default. Done.
	23 <track kind='subtitles' srclang='en' label='English' src='captions-webvtt/ca ptions.vtt' />

	24 </video>

	25 </body>

	26

	27 </html>

OLD	NEW

« no previous file with comments | « no previous file | LayoutTests/media/track/track-disabled-expected.html » ('j') | LayoutTests/media/track/track-disabled-expected.html » ('J')