Reset profile: unpin all pinned tabs

Reset profile: unpin all pinned tabs.
Get rid of all checkboxes in the dialog.

BUG=235037
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=206734

[vasilii, 2013-06-13 18:00:34]

Hi guys,

Could you review this CL?

James: reset_profile_settings_handler.cc
Scott: browser_ui_prefs.cc
Dominic: everything, but especially OWNERS!

[sky, 2013-06-13 18:05:18]

browser_ui_prefs.cc LGTM

[battre, 2013-06-13 18:28:21]

https://codereview.chromium.org/16980002/diff/1009/chrome/browser/ui/browser_...
File chrome/browser/ui/browser_ui_prefs.cc (left):

https://codereview.chromium.org/16980002/diff/1009/chrome/browser/ui/browser_...
chrome/browser/ui/browser_ui_prefs.cc:218:
user_prefs::PrefRegistrySyncable::SYNCABLE_PREF);
You should also remove code from reset_profile_settings_overlay.html that
address this preference (plus the reset_profile_settings_overlay.js file and the
resources).

[vasilii, 2013-06-14 17:21:53]

https://codereview.chromium.org/16980002/diff/1009/chrome/browser/ui/browser_...
File chrome/browser/ui/browser_ui_prefs.cc (left):

https://codereview.chromium.org/16980002/diff/1009/chrome/browser/ui/browser_...
chrome/browser/ui/browser_ui_prefs.cc:218:
user_prefs::PrefRegistrySyncable::SYNCABLE_PREF);
On 2013/06/13 18:28:22, battre wrote:
> You should also remove code from reset_profile_settings_overlay.html that
> address this preference (plus the reset_profile_settings_overlay.js file and
the
> resources).

Done.

[battre, 2013-06-14 17:51:21]

https://codereview.chromium.org/16980002/diff/10001/chrome/browser/profile_re...
File chrome/browser/profile_resetter/profile_resetter.cc (right):

https://codereview.chromium.org/16980002/diff/10001/chrome/browser/profile_re...
chrome/browser/profile_resetter/profile_resetter.cc:60: { STARTUP_PAGES,
&ProfileResetter::ResetStartPage },
want to rename this to ResetStartupPages?

https://codereview.chromium.org/16980002/diff/10001/chrome/browser/ui/webui/o...
File chrome/browser/ui/webui/options/reset_profile_settings_handler.cc (right):

https://codereview.chromium.org/16980002/diff/10001/chrome/browser/ui/webui/o...
chrome/browser/ui/webui/options/reset_profile_settings_handler.cc:63:
scoped_ptr<ListValue> reset_extensions_handling(new ListValue);
This block can be deleted

https://codereview.chromium.org/16980002/diff/10001/chrome/browser/ui/webui/o...
chrome/browser/ui/webui/options/reset_profile_settings_handler.cc:69:
IDS_RESET_PROFILE_EXTENSIONS_DISABLE);
these resources can be deleted from the resource file

https://codereview.chromium.org/16980002/diff/10001/chrome/browser/ui/webui/o...
chrome/browser/ui/webui/options/reset_profile_settings_handler.cc:102: //
TODO(vasilii): remove all UI checkboxes and reset ProfileResetter::ALL.
I think it would be good to have this as part of this CL or to put it completely
into a separate CL.

[vasilii, 2013-06-17 11:56:30]

https://codereview.chromium.org/16980002/diff/10001/chrome/browser/profile_re...
File chrome/browser/profile_resetter/profile_resetter.cc (right):

https://codereview.chromium.org/16980002/diff/10001/chrome/browser/profile_re...
chrome/browser/profile_resetter/profile_resetter.cc:60: { STARTUP_PAGES,
&ProfileResetter::ResetStartPage },
On 2013/06/14 17:51:21, battre wrote:
> want to rename this to ResetStartupPages?

Done.

https://codereview.chromium.org/16980002/diff/10001/chrome/browser/ui/webui/o...
File chrome/browser/ui/webui/options/reset_profile_settings_handler.cc (right):

https://codereview.chromium.org/16980002/diff/10001/chrome/browser/ui/webui/o...
chrome/browser/ui/webui/options/reset_profile_settings_handler.cc:63:
scoped_ptr<ListValue> reset_extensions_handling(new ListValue);
On 2013/06/14 17:51:21, battre wrote:
> This block can be deleted

Done.

https://codereview.chromium.org/16980002/diff/10001/chrome/browser/ui/webui/o...
chrome/browser/ui/webui/options/reset_profile_settings_handler.cc:69:
IDS_RESET_PROFILE_EXTENSIONS_DISABLE);
On 2013/06/14 17:51:21, battre wrote:
> these resources can be deleted from the resource file

Done.

https://codereview.chromium.org/16980002/diff/10001/chrome/browser/ui/webui/o...
chrome/browser/ui/webui/options/reset_profile_settings_handler.cc:102: //
TODO(vasilii): remove all UI checkboxes and reset ProfileResetter::ALL.
On 2013/06/14 17:51:21, battre wrote:
> I think it would be good to have this as part of this CL or to put it
completely
> into a separate CL.

Done.

[battre, 2013-06-17 14:38:48]

lgtm

[vasilii, 2013-06-17 14:40:25]

James?

[James Hawkins, 2013-06-17 15:11:45]

lgtm

[commit-bot: I haz the power, 2013-06-17 15:15:01]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/vasilii@chromium.org/16980002/24001

[commit-bot: I haz the power, 2013-06-17 16:22:52]

Change committed as 206734