Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1153)

Unified Diff: chrome/renderer/resources/extensions/app_window_custom_bindings.js

Issue 16975007: Run shim's watchForTag on document.DOMContentLoaded (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address comments from kalman. Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/renderer/resources/extensions/app_window_custom_bindings.js
diff --git a/chrome/renderer/resources/extensions/app_window_custom_bindings.js b/chrome/renderer/resources/extensions/app_window_custom_bindings.js
index ed0edd1c299770ba99463eb174059bc9eafa0dc1..5d01ff582b1c6fc858b458209623d7e3e3f66049 100644
--- a/chrome/renderer/resources/extensions/app_window_custom_bindings.js
+++ b/chrome/renderer/resources/extensions/app_window_custom_bindings.js
@@ -5,6 +5,7 @@
// Custom binding for the app_window API.
var appWindowNatives = requireNative('app_window_natives');
+var renderViewObserverNatives = requireNative('renderViewObserverNatives');
var Binding = require('binding').Binding;
var Event = require('event_bindings').Event;
var forEach = require('utils').forEach;
@@ -56,14 +57,15 @@ appWindow.registerCustomHook(function(bindingsAPI) {
return;
}
- var willCallback = appWindowNatives.OnContextReady(windowParams.viewId,
- function(success) {
- if (success) {
- callback(view.chrome.app.window.current());
- } else {
- callback(undefined);
- }
- });
+ var willCallback =
+ renderViewObserverNatives.OnDocumentCreated(windowParams.viewId,
+ function(success) {
+ if (success) {
+ callback(view.chrome.app.window.current());
+ } else {
+ callback(undefined);
+ }
+ });
if (!willCallback) {
callback(undefined);
}

Powered by Google App Engine
This is Rietveld 408576698