Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(273)

Unified Diff: chrome/renderer/resources/extensions/web_view.js

Issue 16975007: Run shim's watchForTag on document.DOMContentLoaded (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address comments from kalman. Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/renderer/resources/extensions/web_view.js
diff --git a/chrome/renderer/resources/extensions/web_view.js b/chrome/renderer/resources/extensions/web_view.js
index 1a210ab96808ca0fd140316c3525b979c619112a..ed452042be8cd8f3023bcd16e932bf4356cc729a 100644
--- a/chrome/renderer/resources/extensions/web_view.js
+++ b/chrome/renderer/resources/extensions/web_view.js
@@ -7,6 +7,9 @@
// The actual tag is implemented via the browser plugin. The internals of this
// are hidden via Shadow DOM.
+var appWindowNatives = requireNative('app_window_natives');
+var renderViewObserverNatives = requireNative('renderViewObserverNatives');
+
var forEach = require('utils').forEach;
var watchForTag = require('tagWatcher').watchForTag;
@@ -44,8 +47,13 @@ var WEB_VIEW_EVENTS = {
'unresponsive' : ['processId']
};
lazyboy 2013/06/14 00:30:10 If i refer to "document" here (in file's global sc
-window.addEventListener('DOMContentLoaded', function() {
- watchForTag('WEBVIEW', function(addedNode) { new WebView(addedNode); });
+renderViewObserverNatives.OnDocumentCreatedForCurrentContext(function() {
+ // At this point we have a new document where app's content would go
+ // (document.readyState == 'loading'), run watchForTag() once document's
+ // OnDOMContentLoaded fires.
+ document.addEventListener('DOMContentLoaded', function(e) {
lazyboy 2013/06/14 00:30:10 (See this after next comment) this "document" is d
+ watchForTag('WEBVIEW', function(addedNode) { new WebView(addedNode); });
+ });
});
/**
lazyboy 2013/06/14 00:30:10 (This is not about here) Let's say I have an app

Powered by Google App Engine
This is Rietveld 408576698