Source/bindings/scripts/unstable/v8_interface.py - Issue 169743005: Faster run-bindings-tests

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/scripts/unstable/v8_interface.py

Issue 169743005: Faster run-bindings-tests (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Removed timings and fast is the only mode. Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/bindings/scripts/unstable/v8_interface.py

diff --git a/Source/bindings/scripts/unstable/v8_interface.py b/Source/bindings/scripts/unstable/v8_interface.py

index e75a97b8dec7a78d8dee13bd3935a786f9a04839..ceb2241b161bbe1234841f2531adcee736df5b39 100644

--- a/Source/bindings/scripts/unstable/v8_interface.py

+++ b/Source/bindings/scripts/unstable/v8_interface.py

@@ -66,7 +66,7 @@ INTERFACE_CPP_INCLUDES = set([

def generate_interface(interface):

includes.clear()

includes.update(INTERFACE_CPP_INCLUDES)

- header_includes = INTERFACE_H_INCLUDES

+ header_includes = set(INTERFACE_H_INCLUDES)

Nils Barth (inactive) 2014/02/24 08:38:56 Could you write this as .copy() instead, to make t

Nils Barth (inactive) 2014/02/25 07:29:59 Actually, I grabbed this in: Use a class for CodeG

terry 2014/02/27 23:40:26 Thanks, frozenset is much nicer. On 2014/02/25 07:

parent_interface = interface.parent

if parent_interface: