Faster run-bindings-tests

Source/bindings/scripts/unstable/v8_interface.py

 # Copyright (C) 2013 Google Inc. All rights reserved.
 #
 # Redistribution and use in source and binary forms, with or without
 # modification, are permitted provided that the following conditions are
 # met:
 #
 #     * Redistributions of source code must retain the above copyright
 # notice, this list of conditions and the following disclaimer.
 #     * Redistributions in binary form must reproduce the above
 # copyright notice, this list of conditions and the following disclaimer
@@ skipping 48 matching lines @@
     'core/dom/Document.h',
     'platform/TraceEvent.h',
     'wtf/GetPtr.h',  # FIXME: remove if can eliminate WTF::getPtr
     'wtf/RefPtr.h',
 ])
 
 
 def generate_interface(interface):
     includes.clear()
     includes.update(INTERFACE_CPP_INCLUDES)
-    header_includes = INTERFACE_H_INCLUDES
+    header_includes = set(INTERFACE_H_INCLUDES)

[Nils Barth (inactive), 2014/02/24 08:38:56]

Could you write this as .copy() instead, to make the copying explicit?

[Nils Barth (inactive), 2014/02/25 07:29:59]

Actually, I grabbed this in:
Use a class for CodeGeneratorV8
https://codereview.chromium.org/179423002/
...so this should go away on sync.

Properly it needs to be done for callback interfaces too.
I've made the overall header lists frozenset's to be clear,
so the set() is self-explanatory (mutable copy of an immutable variable).

[terry, 2014/02/27 23:40:26]

Thanks, frozenset is much nicer.
On 2014/02/25 07:29:59, Nils Barth wrote:

 
     parent_interface = interface.parent
     if parent_interface:
         header_includes.update(v8_types.includes_for_type(parent_interface))
     extended_attributes = interface.extended_attributes
 
     is_audio_buffer = inherits_interface(interface.name, 'AudioBuffer')
     if is_audio_buffer:
         includes.add('modules/webaudio/AudioBuffer.h')
 
@@ skipping 629 matching lines @@
         deleter = next(
             method
             for method in interface.operations
             if ('deleter' in method.specials and
                 len(method.arguments) == 1 and
                 method.arguments[0].idl_type == 'DOMString'))
     except StopIteration:
         return None
 
     return property_deleter(deleter)