scripts/slave/recipe_modules/chromium_android/api.py - Issue 1694383003: build: Bot_update refactor recipe roll

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: scripts/slave/recipe_modules/chromium_android/api.py

Issue 1694383003: build: Bot_update refactor recipe roll (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/build

Patch Set: Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: scripts/slave/recipe_modules/chromium_android/api.py

diff --git a/scripts/slave/recipe_modules/chromium_android/api.py b/scripts/slave/recipe_modules/chromium_android/api.py

index 5688df42cab9751e269c5970983db1989c045944..0e9868d9d3ba5e3828d81465b03092dcf1bcae41 100644

--- a/scripts/slave/recipe_modules/chromium_android/api.py

+++ b/scripts/slave/recipe_modules/chromium_android/api.py

@@ -115,8 +115,6 @@ class AndroidApi(recipe_api.RecipeApi):

refs = [refs]

result = self.m.bot_update.ensure_checkout(

spec, refs=refs, with_branch_heads=with_branch_heads)

- if not result.json.output['did_run']:

- result = self.m.gclient.checkout(spec, with_branch_heads=with_branch_heads)

iannucci 2016/02/16 21:04:53 Did chromium_android use bot_update before? Or was

# TODO(sivachandra): Manufacture gclient spec such that it contains "src"

# solution + repo_name solution. Then checkout will be automatically