build: Bot_update refactor recipe roll

scripts/slave/recipe_modules/chromium_android/api.py

 # Copyright 2013 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import contextlib
 import datetime
 import json
 import os
 import re
 import urllib
@@ skipping 97 matching lines @@
     s.managed = self.c.managed
     s.revision = self.c.revision
     spec.revisions = self.c.revisions
 
     self.m.gclient.break_locks()
     refs = self.m.properties.get('event.patchSet.ref')
     if refs:
       refs = [refs]
     result = self.m.bot_update.ensure_checkout(
         spec, refs=refs, with_branch_heads=with_branch_heads)
-    if not result.json.output['did_run']:
-      result = self.m.gclient.checkout(spec, with_branch_heads=with_branch_heads)

[iannucci, 2016/02/16 21:04:53]

Did chromium_android use bot_update before? Or was it blacklisted out?

 
     # TODO(sivachandra): Manufacture gclient spec such that it contains "src"
     # solution + repo_name solution. Then checkout will be automatically
     # correctly set by gclient.checkout
     self.m.path['checkout'] = self.m.path['slave_build'].join('src')
 
     self.clean_local_files()
 
     return result
 
@@ skipping 1097 matching lines @@
   def test_runner(self, step_name, args=None, **kwargs):
     """Wrapper for the python testrunner script.
 
     Args:
       step_name: Name of the step.
       args: Testrunner arguments.
     """
     with self.handle_exit_codes():
       return self.m.python(
           step_name, self.c.test_runner, args, **kwargs)