Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(861)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: scripts/slave/recipes/run_presubmit.py

Issue 1694383003: build: Bot_update refactor recipe roll (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/build
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« scripts/slave/recipe_modules/chromium_android/api.py ('K') | « scripts/slave/recipes/perf/telemetry_harness_upload.expected/basic.json ('k') | scripts/slave/recipes/run_presubmit.expected/build.json » ('j') | scripts/slave/recipes/swarming/staging.py » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: scripts/slave/recipes/run_presubmit.py
diff --git a/scripts/slave/recipes/run_presubmit.py b/scripts/slave/recipes/run_presubmit.py
index 3f9952b7324abf2dc047d1a754db439c8b7056e4..c23b95588323fc251dd7f1a333df63b33d6e6af9 100644
--- a/scripts/slave/recipes/run_presubmit.py
+++ b/scripts/slave/recipes/run_presubmit.py
@@ -35,12 +35,6 @@ def _RunStepsInternal(api):
got_revision_property = api.gclient.c.got_revision_mapping[relative_root]
upstream = bot_update_step.json.output['properties'].get(
got_revision_property)
- if (not upstream or
- isinstance(upstream, int) or
- (upstream.isdigit() and len(upstream) < 40)):
- # If got_revision is an svn revision, then use got_revision_git.
- upstream = bot_update_step.json.output['properties'].get(
- '%s_git' % got_revision_property) or ''
# TODO(hinoka): Extract email/name from issue?
api.git('-c', 'user.email=commit-bot@chromium.org',
« scripts/slave/recipe_modules/chromium_android/api.py ('K') | « scripts/slave/recipes/perf/telemetry_harness_upload.expected/basic.json ('k') | scripts/slave/recipes/run_presubmit.expected/build.json » ('j') | scripts/slave/recipes/swarming/staging.py » ('J')

Powered by Google App Engine
This is Rietveld 408576698