cc: flush the drawing before unlocking the filtered source

cc: Flush the drawing before unlocking the filtered source

Flush the drawing before unlocking the filtered source texture. This
fixes the bugs related to overwriting the source texture before Skia
uses it.

BUG=582858
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Committed: https://crrev.com/69331d9d7b17909d4e8d2e2a4ea7d3ee33d34a11
Cr-Commit-Position: refs/heads/master@{#375143}

[Kimmo Kinnunen, 2016-02-11 16:16:22]

Description was changed from

==========
cc: flush the drawing before unlocking the filtered source

Flush the drawing before unlocking the filtered source texture. This
fixes the bugs related to overwriting the source texture before Skia
uses it.

BUG=582858
==========

to

==========
cc: flush the drawing before unlocking the filtered source

Flush the drawing before unlocking the filtered source texture. This
fixes the bugs related to overwriting the source texture before Skia
uses it.

BUG=582858
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

[Kimmo Kinnunen, 2016-02-11 16:23:19]

The CQ bit was checked by kkinnunen@nvidia.com to run a CQ dry run

[commit-bot: I haz the power, 2016-02-11 16:24:57]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1692563003/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1692563003/1

[Kimmo Kinnunen, 2016-02-11 17:02:54]

kkinnunen@nvidia.com changed reviewers:
+ ericrk@chromium.org, senorblanco@chromium.org

[Kimmo Kinnunen, 2016-02-11 18:51:45]

kkinnunen@nvidia.com changed reviewers:
+ bsalomon@google.com

[Kimmo Kinnunen, 2016-02-11 18:51:45]

https://chromiumcodereview.appspot.com/1692563003/diff/1/cc/output/gl_rendere...
File cc/output/gl_renderer.cc (right):

https://chromiumcodereview.appspot.com/1692563003/diff/1/cc/output/gl_rendere...
cc/output/gl_renderer.cc:662: surface->getCanvas()->flush();
Note: naturally this trades off msaa perf for correctness.
Most of the perf regression could be gained back with Brian's envisioned
SkSurface::flushButNotResolve() and SkSurface::prepareForExternalIO() API
additions.

[commit-bot: I haz the power, 2016-02-11 19:26:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-11 19:26:27]

Dry run: This issue passed the CQ dry run.

[ericrk, 2016-02-11 22:03:20]

lgtm

https://codereview.chromium.org/1692563003/diff/1/cc/output/gl_renderer.cc
File cc/output/gl_renderer.cc (right):

https://codereview.chromium.org/1692563003/diff/1/cc/output/gl_renderer.cc#ne...
cc/output/gl_renderer.cc:662: surface->getCanvas()->flush();
On 2016/02/11 at 18:51:45, Kimmo Kinnunen wrote:
> Note: naturally this trades off msaa perf for correctness.
> Most of the perf regression could be gained back with Brian's envisioned
SkSurface::flushButNotResolve() and SkSurface::prepareForExternalIO() API
additions.

Ok... Now I understand what's going on here a bit better... We need this change
independent of the other one. Thanks for explaining!

[Kimmo Kinnunen, 2016-02-12 07:13:37]

Description was changed from

==========
cc: flush the drawing before unlocking the filtered source

Flush the drawing before unlocking the filtered source texture. This
fixes the bugs related to overwriting the source texture before Skia
uses it.

BUG=582858
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

to

==========
cc: Flush the drawing before unlocking the filtered source

Flush the drawing before unlocking the filtered source texture. This
fixes the bugs related to overwriting the source texture before Skia
uses it.

BUG=582858
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

[Kimmo Kinnunen, 2016-02-12 07:13:43]

The CQ bit was checked by kkinnunen@nvidia.com

[commit-bot: I haz the power, 2016-02-12 07:13:53]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1692563003/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1692563003/1

[commit-bot: I haz the power, 2016-02-12 07:21:00]

Description was changed from

==========
cc: Flush the drawing before unlocking the filtered source

Flush the drawing before unlocking the filtered source texture. This
fixes the bugs related to overwriting the source texture before Skia
uses it.

BUG=582858
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

to

==========
cc: Flush the drawing before unlocking the filtered source

Flush the drawing before unlocking the filtered source texture. This
fixes the bugs related to overwriting the source texture before Skia
uses it.

BUG=582858
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

[commit-bot: I haz the power, 2016-02-12 07:21:01]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-02-16 22:42:13]

Description was changed from

==========
cc: Flush the drawing before unlocking the filtered source

Flush the drawing before unlocking the filtered source texture. This
fixes the bugs related to overwriting the source texture before Skia
uses it.

BUG=582858
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

to

==========
cc: Flush the drawing before unlocking the filtered source

Flush the drawing before unlocking the filtered source texture. This
fixes the bugs related to overwriting the source texture before Skia
uses it.

BUG=582858
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Committed: https://crrev.com/69331d9d7b17909d4e8d2e2a4ea7d3ee33d34a11
Cr-Commit-Position: refs/heads/master@{#375143}
==========

[commit-bot: I haz the power, 2016-02-16 22:42:14]

Patchset 1 (id:??) landed as
https://crrev.com/69331d9d7b17909d4e8d2e2a4ea7d3ee33d34a11
Cr-Commit-Position: refs/heads/master@{#375143}