cc: Avoid extra flush calls to Skia GrContext

cc: Avoid extra flush calls to Skia GrContext

Avoid calling GrContext::flush() upon every tile raster.  The correct
way to ensure rendering has been submitted to GPU API level is by
"preparing for external io" the render target.

This fixes the problem where Skia GPU resource cache resources grow
old too quickly.  Each flush will age the resources, and after
becoming too old (64), the resources will be redundantly destroyed upon
the next resource allocation. The flush is intended to be called at the
rate the order of frames. Before this fix, the flush was called at least
the amount relative to the amount of tiles. For MSAA, flush was called
more than one time per tile. This fix reduces the amount of flushes.
Also, after this fix the effect of potential extra flushes can be fixed
in Skia.

BUG=582858
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

[Kimmo Kinnunen, 2016-02-11 16:50:06]

Description was changed from

==========
cc: Avoid extra flush calls to Skia GrContext

Avoid calling GrContext::flush() upon every tile raster.  The correct
way to ensure rendering has been submitted to GPU API level is by
"preparing for external io" the render target.

This fixes the problem where Skia GPU resource cache resources grow
old too quickly.  Each flush will age the resources, and after
becoming too old (64), the resources will be redundantly destroyed upon
the next resource allocation. The flush is intended to be called at the
rate the order of frames. Before this fix, the flush was called at least
the amount relative to the amount of tiles. For MSAA, flush was called
more than one time per tile. This fix reduces the amount of flushes.
Also, after this fix the effect of potential extra flushes can be fixed
in Skia.

BUG=582858
==========

to

==========
cc: Avoid extra flush calls to Skia GrContext

Avoid calling GrContext::flush() upon every tile raster.  The correct
way to ensure rendering has been submitted to GPU API level is by
"preparing for external io" the render target.

This fixes the problem where Skia GPU resource cache resources grow
old too quickly.  Each flush will age the resources, and after
becoming too old (64), the resources will be redundantly destroyed upon
the next resource allocation. The flush is intended to be called at the
rate the order of frames. Before this fix, the flush was called at least
the amount relative to the amount of tiles. For MSAA, flush was called
more than one time per tile. This fix reduces the amount of flushes.
Also, after this fix the effect of potential extra flushes can be fixed
in Skia.

BUG=582858
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

[Kimmo Kinnunen, 2016-02-11 16:58:16]

Patchset #1 (id:1) has been deleted

[Kimmo Kinnunen, 2016-02-11 17:03:10]

kkinnunen@nvidia.com changed reviewers:
+ ericrk@chromium.org, senorblanco@chromium.org

[Kimmo Kinnunen, 2016-02-11 17:03:11]

alternative 2

[ericrk, 2016-02-12 00:06:13]

On 2016/02/11 at 17:03:11, kkinnunen wrote:
> alternative 2

This is fine as well - but now that I understand the previous change, I think
that's the better option. LGTM - up to you which one you prefer.

[Kimmo Kinnunen, 2016-02-12 12:13:32]

Description was changed from

==========
cc: Avoid extra flush calls to Skia GrContext

Avoid calling GrContext::flush() upon every tile raster.  The correct
way to ensure rendering has been submitted to GPU API level is by
"preparing for external io" the render target.

This fixes the problem where Skia GPU resource cache resources grow
old too quickly.  Each flush will age the resources, and after
becoming too old (64), the resources will be redundantly destroyed upon
the next resource allocation. The flush is intended to be called at the
rate the order of frames. Before this fix, the flush was called at least
the amount relative to the amount of tiles. For MSAA, flush was called
more than one time per tile. This fix reduces the amount of flushes.
Also, after this fix the effect of potential extra flushes can be fixed
in Skia.

BUG=582858
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

to

==========
cc: Avoid extra flush calls to Skia GrContext

Avoid calling GrContext::flush() upon every tile raster.  The correct
way to ensure rendering has been submitted to GPU API level is by
"preparing for external io" the render target.

This fixes the problem where Skia GPU resource cache resources grow
old too quickly.  Each flush will age the resources, and after
becoming too old (64), the resources will be redundantly destroyed upon
the next resource allocation. The flush is intended to be called at the
rate the order of frames. Before this fix, the flush was called at least
the amount relative to the amount of tiles. For MSAA, flush was called
more than one time per tile. This fix reduces the amount of flushes.
Also, after this fix the effect of potential extra flushes can be fixed
in Skia.

BUG=582858
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========