Issue 16914003: Fix SVG animations which set rx or ry attributes

Issue 16914003: Fix SVG animations which set rx or ry attributes (Closed)

Created:
7 years, 6 months ago by mrunal

Modified:
7 years, 6 months ago

Reviewers:
pdr.

CC:
blink-reviews, eae+blinkwatch, leviw+renderwatch, f(malita), jchaffraix+rendering, pdr, Stephen Chennney

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Visibility:
Public.

Fix SVG animations which set rx or ry attributes Earlier to update path on Rect, hasAttribute() was used to check if the rx or ry attributes are present. Now it checks if the rx or ry are greater than zero. BUG=235256 R=pdr@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=152376

Total comments: 1

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+27 lines, -6 lines)			Patch
A	LayoutTests/svg/stroke/animated-non-scaling-rxry.html	View	1	1 chunk	+12 lines, -0 lines	0 comments	Download
A	LayoutTests/svg/stroke/animated-non-scaling-rxry-expected.html	View	1	1 chunk	+9 lines, -0 lines	0 comments	Download
M	Source/core/rendering/svg/RenderSVGRect.cpp	View		1 chunk	+4 lines, -4 lines	0 comments	Download
M	Source/core/rendering/svg/SVGPathData.cpp	View		1 chunk	+2 lines, -2 lines	0 comments	Download

Total messages: 4 (0 generated)

pdr.

LGTM! Great patch :) I have a few very minor nits around test cleanliness. Do ...

7 years, 6 months ago (2013-06-13 03:09:17 UTC) #1

mrunal

Thanks :) I have uploaded the 2nd patch to take care of the nits. Thanks ...

7 years, 6 months ago (2013-06-13 19:13:02 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mrunal.kapade@intel.com/16914003/4001

7 years, 6 months ago (2013-06-13 19:13:17 UTC) #3

Message was sent while issue was closed.

Change committed as 152376