Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1299)

Unified Diff: Source/core/rendering/svg/SVGPathData.cpp

Issue 16914003: Fix SVG animations which set rx or ry attributes (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Update tests with minor nits Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/rendering/svg/RenderSVGRect.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/rendering/svg/SVGPathData.cpp
diff --git a/Source/core/rendering/svg/SVGPathData.cpp b/Source/core/rendering/svg/SVGPathData.cpp
index af95a60187bfccb6e2762c9867bd92b32c78694e..0879b8b831ece367f6f7cfeb2fe3fe680a0d25bb 100644
--- a/Source/core/rendering/svg/SVGPathData.cpp
+++ b/Source/core/rendering/svg/SVGPathData.cpp
@@ -124,8 +124,8 @@ static void updatePathFromRectElement(SVGElement* element, Path& path)
return;
float x = rect->x().value(lengthContext);
float y = rect->y().value(lengthContext);
- bool hasRx = rect->hasAttribute(SVGNames::rxAttr);
- bool hasRy = rect->hasAttribute(SVGNames::ryAttr);
+ bool hasRx = rect->rx().value(lengthContext) > 0;
+ bool hasRy = rect->ry().value(lengthContext) > 0;
if (hasRx || hasRy) {
float rx = rect->rx().value(lengthContext);
float ry = rect->ry().value(lengthContext);
« no previous file with comments | « Source/core/rendering/svg/RenderSVGRect.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698