Issue 16910002: Destroy StorageMonitorCros before DBusServices (take 2)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 16910002: Destroy StorageMonitorCros before DBusServices (take 2) (Closed)

Created:
7 years, 6 months ago by stevenjb

Modified:
7 years, 6 months ago

Reviewers:
Lei Zhang, Greg Billock

CC:
chromium-reviews, oshima+watch_chromium.org, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, davemoore+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Destroy StorageMonitorCros before DBusServices (take 2) We need to check the StorageMonitor singleton before removing observers in destructors. BUG=249117 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=206262

Patch Set 1 #

Total comments: 1

Patch Set 2 : Rebase #

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -1 line)			Patch
	M	chrome/browser/chromeos/chrome_browser_main_chromeos.cc	View		1 chunk	+1 line, -0 lines	0 comments	Download
	M	chrome/browser/media_galleries/media_galleries_dialog_controller.cc	View	1	1 chunk	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Greg Billock

lgtm https://codereview.chromium.org/16910002/diff/1/chrome/browser/media_galleries/media_galleries_preferences.cc File chrome/browser/media_galleries/media_galleries_preferences.cc (right): https://codereview.chromium.org/16910002/diff/1/chrome/browser/media_galleries/media_galleries_preferences.cc#newcode265 chrome/browser/media_galleries/media_galleries_preferences.cc:265: if (StorageMonitor::GetInstance()) This should merge out now since ...

7 years, 6 months ago (2013-06-13 14:55:31 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/stevenjb@chromium.org/16910002/6001

7 years, 6 months ago (2013-06-13 22:06:50 UTC) #3

Message was sent while issue was closed.

Change committed as 206262

Expand Messages | Collapse Messages