Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(211)

Issue 1689693003: Update PEM file pretty-printer for putting comment blocks on top. (Closed)

Created:
4 years, 10 months ago by eroman
Modified:
4 years, 10 months ago
Reviewers:
mattm
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update PEM file pretty-printer for putting comment blocks on top. This is a follow-up to https://codereview.chromium.org/1658693006/ which updated the various data files. Committed: https://crrev.com/e47204cae975e1fdf0729e3716cabae5564ff6d0 Cr-Commit-Position: refs/heads/master@{#375096}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -17 lines) Patch
M net/data/verify_signed_data_unittest/annotate_test_data.py View 5 chunks +14 lines, -17 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
eroman
4 years, 10 months ago (2016-02-11 01:43:59 UTC) #2
mattm
lgtm
4 years, 10 months ago (2016-02-11 04:03:15 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1689693003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1689693003/1
4 years, 10 months ago (2016-02-11 05:47:18 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: android_chromium_gn_compile_rel on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_chromium_gn_compile_rel/builds/20680)
4 years, 10 months ago (2016-02-11 06:40:45 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1689693003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1689693003/1
4 years, 10 months ago (2016-02-12 01:56:34 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-12 02:25:04 UTC) #10
commit-bot: I haz the power
4 years, 10 months ago (2016-02-16 22:40:59 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e47204cae975e1fdf0729e3716cabae5564ff6d0
Cr-Commit-Position: refs/heads/master@{#375096}

Powered by Google App Engine
This is Rietveld 408576698